mac802154: Fix an always true condition

At this stage we simply do not care about the delayed work value,
because active scan is not yet supported, so we can blindly queue
another work once a beacon has been sent.

It fixes a smatch warning:
    mac802154_beacon_worker() warn: always true condition
    '(local->beacon_interval >= 0) => (0-u32max >= 0)'

Fixes: 3accf4762734 ("mac802154: Handle basic beaconing")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20230214135035.1202471-6-miquel.raynal@bootlin.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>

diff --git a/net/mac802154/scan.c b/net/mac802154/scan.c
index fff41e59099ebd10942438368319a165909787f0..9b0933a185ebc9981ff8c64478742f7f6e9d8e9e 100644 (file)
--- a/net/mac802154/scan.c
+++ b/net/mac802154/scan.c
@@ -383,9 +383,8 @@ void mac802154_beacon_worker(struct work_struct *work)
                dev_err(&sdata->dev->dev,
                        "Beacon could not be transmitted (%d)\n", ret);
 
-       if (local->beacon_interval >= 0)
-               queue_delayed_work(local->mac_wq, &local->beacon_work,
-                                  local->beacon_interval);
+       queue_delayed_work(local->mac_wq, &local->beacon_work,
+                          local->beacon_interval);
 }
 
 int mac802154_stop_beacons_locked(struct ieee802154_local *local,