SVACE: The standard has been applied(Critical).

- HANDLE_LEAK(256442) ConnectionHistoryJSONParser
- HANDLE_LEAK(256443) SSHUtil
- HANDLE_LEAK(256444) SSHUtil
- HANDLE_LEAK(256449) ConnectionHistoryJSONWriter
- HANDLE_LEAK(256444) WebGitIndexParser
- DEREF_OF_NULL.EX(256624) RootstrapViewProvider
- DEREF_OF_NULL.EX(256626) RootstrapViewProvider

Signed-off-by: JaeMin Kim <jm.jemin.kim@samsung.com>

diff --git a/org.tizen.nativeplatform.project.wizard/src/org/tizen/nativeplatform/project/wizard/git/parser/WebGitIndexParser.java b/org.tizen.nativeplatform.project.wizard/src/org/tizen/nativeplatform/project/wizard/git/parser/WebGitIndexParser.java
index 424cdd1..f40ba7e 100644 (file)
--- a/org.tizen.nativeplatform.project.wizard/src/org/tizen/nativeplatform/project/wizard/git/parser/WebGitIndexParser.java
+++ b/org.tizen.nativeplatform.project.wizard/src/org/tizen/nativeplatform/project/wizard/git/parser/WebGitIndexParser.java
@@ -121,6 +121,11 @@ public class WebGitIndexParser implements IGitIndexParser {
             while ((line = in.readLine()) != null) {
                 out.write(line + "\n");
             }
+
+            if (cacheFile.exists()) {
+                return true;
+            }
+
         } catch (MalformedURLException e) {
             e.printStackTrace();
             throw new InterruptedException(e.toString());
@@ -131,9 +136,6 @@ public class WebGitIndexParser implements IGitIndexParser {
             IOUtil.tryClose(in);
             IOUtil.tryClose(out);
         }
-        if (cacheFile.exists()) {
-            return true;
-        }
         return false;
     }
 

diff --git a/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/remote/connection/history/ConnectionHistoryJSONParser.java b/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/remote/connection/history/ConnectionHistoryJSONParser.java
index dd20e2e..c25d5bd 100644 (file)
--- a/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/remote/connection/history/ConnectionHistoryJSONParser.java
+++ b/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/remote/connection/history/ConnectionHistoryJSONParser.java
@@ -80,9 +80,10 @@ public class ConnectionHistoryJSONParser {
                 }
             }
         } catch (Exception e) {
-            IOUtil.tryClose(fileReader);
             logger.error(resources.getString("Err.filaedToParseJson"), e);
             return false;
+        } finally {
+            IOUtil.tryClose(fileReader);
         }
         return true;
     }

diff --git a/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/remote/connection/history/ConnectionHistoryJSONWriter.java b/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/remote/connection/history/ConnectionHistoryJSONWriter.java
index d5ca688..16efa38 100644 (file)
--- a/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/remote/connection/history/ConnectionHistoryJSONWriter.java
+++ b/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/remote/connection/history/ConnectionHistoryJSONWriter.java
@@ -61,7 +61,6 @@ public class ConnectionHistoryJSONWriter {
             String json = gson.toJson(ConnectionHistory.getConnectionList());
             writer = new FileWriter(jsonFile);
             writer.write(json);
-            writer.close();
         } catch (Exception e) {
             logger.error(resources.getString("Err.filaedToParseJson"), e);
             return false;

diff --git a/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/rootstrap/RootstrapViewProvider.java b/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/rootstrap/RootstrapViewProvider.java
index dd1b98b..5871496 100644 (file)
--- a/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/rootstrap/RootstrapViewProvider.java
+++ b/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/rootstrap/RootstrapViewProvider.java
@@ -117,7 +117,7 @@ public class RootstrapViewProvider implements IRootstrapViewProvider {
             }
         }
 
-        if (createAction != null) {
+        if (createAction != null && connectAction != null && disconnectAction != null) {
             if (RemoteConnectionManager.connected()) {
                 createAction.getAction().setEnabled(true);
                 connectAction.getAction().setEnabled(false);

diff --git a/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/util/SSHUtil.java b/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/util/SSHUtil.java
index 0be10d0..d39d645 100644 (file)
--- a/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/util/SSHUtil.java
+++ b/org.tizen.nativeplatform.win/src/org/tizen/nativeplatform/win/util/SSHUtil.java
@@ -93,9 +93,10 @@ public class SSHUtil {
                 return false;
             }
         } catch (Exception e) {
+            logger.error("Failed to register authorized key", e);
+        } finally {
             IOUtil.tryClose(fileReader);
             IOUtil.tryClose(reader);
-            logger.error("Failed to register authorized key", e);
         }
         return true;
     }