gpio: aspeed: Remove dependence on GPIOF_* macros
authorAndrew Jeffery <andrew@aj.id.au>
Thu, 2 Feb 2017 04:28:17 +0000 (14:58 +1030)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 4 Feb 2017 20:34:55 +0000 (21:34 +0100)
1736f75d35e47409ad776273133d0f558a4c8253 is a (v2) patch which had
unresolved review comments[1]. Address the comments by removing the use
of macros from the consumer header (this patch represents the diff
between v2 and v3[2]).

[1] https://lkml.org/lkml/2017/1/26/337
[2] https://lkml.org/lkml/2017/1/26/786

Fixes: 1736f75d35e4 ("gpio: aspeed: Add banks Y, Z, AA, AB and AC")
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Acked-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-aspeed.c

index 6e4b278..fb16cc7 100644 (file)
@@ -15,7 +15,6 @@
 #include <linux/io.h>
 #include <linux/spinlock.h>
 #include <linux/platform_device.h>
-#include <linux/gpio.h>
 #include <linux/gpio/driver.h>
 #include <linux/pinctrl/consumer.h>
 
@@ -259,10 +258,10 @@ static int aspeed_gpio_get_direction(struct gpio_chip *gc, unsigned int offset)
        u32 val;
 
        if (!have_input(gpio, offset))
-               return GPIOF_DIR_OUT;
+               return 0;
 
        if (!have_output(gpio, offset))
-               return GPIOF_DIR_IN;
+               return 1;
 
        spin_lock_irqsave(&gpio->lock, flags);