spi: dw: Fix PM disable depth imbalance in dw_spi_bt1_probe
authorZhang Qilong <zhangqilong3@huawei.com>
Sat, 24 Sep 2022 12:13:08 +0000 (20:13 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 26 Sep 2022 15:10:36 +0000 (16:10 +0100)
The pm_runtime_enable will increase power disable depth. Thus
a pairing decrement is needed on the error handling path to
keep it balanced according to context.

Fixes:abf00907538e2 ("spi: dw: Add Baikal-T1 SPI Controller glue driver")

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20220924121310.78331-3-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-dw-bt1.c

index c065534..3fb89de 100644 (file)
@@ -293,8 +293,10 @@ static int dw_spi_bt1_probe(struct platform_device *pdev)
        pm_runtime_enable(&pdev->dev);
 
        ret = dw_spi_add_host(&pdev->dev, dws);
-       if (ret)
+       if (ret) {
+               pm_runtime_disable(&pdev->dev);
                goto err_disable_clk;
+       }
 
        platform_set_drvdata(pdev, dwsbt1);