staging: rtl8723bs: remove useless typedef's in HalPhyRf.h

This commit fixes the following checkpatch.pl warnings:

    WARNING: do not add new typedefs
    #11: FILE: hal/HalPhyRf.h:11:
    +typedef enum _SPUR_CAL_METHOD {

    WARNING: do not add new typedefs
    #16: FILE: hal/HalPhyRf.h:16:
    +typedef enum _PWRTRACK_CONTROL_METHOD {

    WARNING: do not add new typedefs
    #27: FILE: hal/HalPhyRf.h:27:
    +typedef struct _TXPWRTRACK_CFG {

Signed-off-by: Marco Cesati <marco.cesati@gmail.com>
Link: https://lore.kernel.org/r/20210305144906.18850-1-marco.cesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf.c b/drivers/staging/rtl8723bs/hal/HalPhyRf.c
index 7b43584..491bf73 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf.c
@@ -23,7 +23,7 @@
        } while (0)
 
 
-void ConfigureTxpowerTrack(PDM_ODM_T pDM_Odm, PTXPWRTRACK_CFG pConfig)
+void ConfigureTxpowerTrack(PDM_ODM_T pDM_Odm, struct TXPWRTRACK_CFG * pConfig)
 {
        ConfigureTxpowerTrack_8723B(pConfig);
 }
@@ -83,7 +83,7 @@ void ODM_TXPowerTrackingCallback_ThermalMeter(struct adapter *Adapter)
        u8 OFDM_min_index = 0;  /*  OFDM BB Swing should be less than +3.0dB, which is required by Arthur */
        u8 Indexforchannel = 0; /*  GetRightChnlPlaceforIQK(pHalData->CurrentChannel) */
 
-       TXPWRTRACK_CFG c;
+       struct TXPWRTRACK_CFG c;
 
 
        /* 4 1. The following TWO tables decide the final index of OFDM/CCK swing table. */

diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf.h b/drivers/staging/rtl8723bs/hal/HalPhyRf.h
index 643fcf3..5adccb9 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf.h
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf.h
@@ -8,23 +8,23 @@
  #ifndef __HAL_PHY_RF_H__
  #define __HAL_PHY_RF_H__
 
-typedef enum _SPUR_CAL_METHOD {
+enum SPUR_CAL_METHOD {
        PLL_RESET,
        AFE_PHASE_SEL
-} SPUR_CAL_METHOD;
+};
 
-typedef enum _PWRTRACK_CONTROL_METHOD {
+enum PWRTRACK_METHOD {
        BBSWING,
        TXAGC,
        MIX_MODE
-} PWRTRACK_METHOD;
+};
 
-typedef void (*FuncSetPwr)(PDM_ODM_T, PWRTRACK_METHOD, u8, u8);
+typedef void (*FuncSetPwr)(PDM_ODM_T, enum PWRTRACK_METHOD, u8, u8);
 typedef void (*FuncIQK)(PDM_ODM_T, u8, u8, u8);
 typedef void (*FuncLCK)(PDM_ODM_T);
 typedef void (*FuncSwing)(PDM_ODM_T, u8 **, u8 **, u8 **, u8 **);
 
-typedef struct _TXPWRTRACK_CFG {
+struct TXPWRTRACK_CFG {
        u8 SwingTableSize_CCK;
        u8 SwingTableSize_OFDM;
        u8 Threshold_IQK;
@@ -35,9 +35,9 @@ typedef struct _TXPWRTRACK_CFG {
        FuncIQK DoIQK;
        FuncLCK PHY_LCCalibrate;
        FuncSwing GetDeltaSwingTable;
-} TXPWRTRACK_CFG, *PTXPWRTRACK_CFG;
+};
 
-void ConfigureTxpowerTrack(PDM_ODM_T pDM_Odm, PTXPWRTRACK_CFG pConfig);
+void ConfigureTxpowerTrack(PDM_ODM_T pDM_Odm, struct TXPWRTRACK_CFG * pConfig);
 
 
 void ODM_ClearTxPowerTrackingState(PDM_ODM_T pDM_Odm);

diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
index 645f4f2..d8b3b20 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
@@ -186,7 +186,7 @@ void DoIQK_8723B(
  *---------------------------------------------------------------------------*/
 void ODM_TxPwrTrackSetPwr_8723B(
        PDM_ODM_T pDM_Odm,
-       PWRTRACK_METHOD Method,
+       enum PWRTRACK_METHOD Method,
        u8 RFPath,
        u8 ChannelMappedIndex
 )
@@ -409,7 +409,7 @@ static void GetDeltaSwingTable_8723B(
 }
 
 
-void ConfigureTxpowerTrack_8723B(PTXPWRTRACK_CFG pConfig)
+void ConfigureTxpowerTrack_8723B(struct TXPWRTRACK_CFG * pConfig)
 {
        pConfig->SwingTableSize_CCK = CCK_TABLE_SIZE;
        pConfig->SwingTableSize_OFDM = OFDM_TABLE_SIZE;

diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h
index a4d5150..c61d39a 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h
+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.h
@@ -16,7 +16,7 @@
 #define        RF_T_METER_8723B                                        0x42    /*  */
 
 
-void ConfigureTxpowerTrack_8723B(PTXPWRTRACK_CFG       pConfig);
+void ConfigureTxpowerTrack_8723B(struct TXPWRTRACK_CFG * pConfig);
 
 void DoIQK_8723B(
        PDM_ODM_T pDM_Odm,
@@ -27,7 +27,7 @@ void DoIQK_8723B(
 
 void ODM_TxPwrTrackSetPwr_8723B(
        PDM_ODM_T pDM_Odm,
-       PWRTRACK_METHOD Method,
+       enum PWRTRACK_METHOD Method,
        u8 RFPath,
        u8 ChannelMappedIndex
 );