[media] tw5864: remove double irq lock code
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 24 Aug 2016 16:26:50 +0000 (13:26 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 24 Aug 2016 16:30:59 +0000 (13:30 -0300)
As warned by smatch:
drivers/media/pci/tw5864/tw5864-core.c:160 tw5864_h264_isr() error: double lock 'irqsave:flags'
drivers/media/pci/tw5864/tw5864-core.c:174 tw5864_h264_isr() error: double unlock 'irqsave:flags'

Remove the IRQ duplicated lock.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/tw5864/tw5864-core.c

index 440cd7b..e3d884e 100644 (file)
@@ -157,12 +157,10 @@ static void tw5864_h264_isr(struct tw5864_dev *dev)
 
                cur_frame = next_frame;
 
-               spin_lock_irqsave(&input->slock, flags);
                input->frame_seqno++;
                input->frame_gop_seqno++;
                if (input->frame_gop_seqno >= input->gop)
                        input->frame_gop_seqno = 0;
-               spin_unlock_irqrestore(&input->slock, flags);
        } else {
                dev_err(&dev->pci->dev,
                        "Skipped frame on input %d because all buffers busy\n",