phy: tegra: xusb: Use dev_err_probe() to simplify code
authorYuan Can <yuancan@huawei.com>
Thu, 22 Sep 2022 09:22:43 +0000 (09:22 +0000)
committerVinod Koul <vkoul@kernel.org>
Sat, 24 Sep 2022 07:04:56 +0000 (12:34 +0530)
In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs.

Signed-off-by: Yuan Can <yuancan@huawei.com>
Link: https://lore.kernel.org/r/20220922092243.22281-1-yuancan@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/tegra/xusb-tegra186.c

index ae3915e..f1643fb 100644 (file)
@@ -1381,12 +1381,9 @@ tegra186_xusb_read_fuse_calibration(struct tegra186_xusb_padctl *padctl)
                return -ENOMEM;
 
        err = tegra_fuse_readl(TEGRA_FUSE_SKU_CALIB_0, &value);
-       if (err) {
-               if (err != -EPROBE_DEFER)
-                       dev_err(dev, "failed to read calibration fuse: %d\n",
-                               err);
-               return err;
-       }
+       if (err)
+               return dev_err_probe(dev, err,
+                                    "failed to read calibration fuse\n");
 
        dev_dbg(dev, "FUSE_USB_CALIB_0 %#x\n", value);