staging: vme_user: refactor llseek to switch(){}
authorDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Thu, 28 May 2015 12:07:02 +0000 (15:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Jun 2015 00:26:57 +0000 (17:26 -0700)
This makes vme_user_llseek ignore all minors that don't have llseek
implementation.

Signed-off-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vme/devices/vme_user.c

index 19ba749..da828f4 100644 (file)
@@ -430,15 +430,17 @@ static loff_t vme_user_llseek(struct file *file, loff_t off, int whence)
        size_t image_size;
        loff_t res;
 
-       if (minor == CONTROL_MINOR)
-               return -EINVAL;
-
-       mutex_lock(&image[minor].mutex);
-       image_size = vme_get_size(image[minor].resource);
-       res = fixed_size_llseek(file, off, whence, image_size);
-       mutex_unlock(&image[minor].mutex);
+       switch (type[minor]) {
+       case MASTER_MINOR:
+       case SLAVE_MINOR:
+               mutex_lock(&image[minor].mutex);
+               image_size = vme_get_size(image[minor].resource);
+               res = fixed_size_llseek(file, off, whence, image_size);
+               mutex_unlock(&image[minor].mutex);
+               return res;
+       }
 
-       return res;
+       return -EINVAL;
 }
 
 /*