git.rev_parse: unconditionally use --quiet

to avoid the confusing "fatal: Needed a single revision" error message

diff --git a/gbp/deb.py b/gbp/deb.py
index 1a53563..ff361d6 100644 (file)
--- a/gbp/deb.py
+++ b/gbp/deb.py
@@ -181,7 +181,7 @@ def parse_changelog_repo(repo, branch, filename):
         # to show as well, but we want to check if the branch / filename
         # exists first, so we can give a separate error from other
         # repository errors.
-        sha = repo.rev_parse("%s:%s" % (branch, filename), quiet=True)
+        sha = repo.rev_parse("%s:%s" % (branch, filename))
     except GitRepositoryError:
         raise NoChangelogError, "Changelog %s not found in branch %s" % (filename, branch)
 

diff --git a/gbp/git.py b/gbp/git.py
index 04fef6a..4f2507f 100644 (file)
--- a/gbp/git.py
+++ b/gbp/git.py
@@ -324,11 +324,9 @@ class GitRepository(object):
             raise GitRepositoryError, "can't find tag for %s" % commit
         return tag[0].strip()
 
-    def rev_parse(self, name, quiet=False):
+    def rev_parse(self, name):
         "find the SHA1"
-        args = [ "--verify", name]
-        if quiet:
-            args.insert(0, "--quiet")
+        args = [ "--quiet", "--verify", name ]
         sha, ret = self.__git_getoutput('rev-parse', args)
         if ret:
             raise GitRepositoryError, "revision '%s' not found" % name