ata: libata-core: remove redundant err_mask variable
authorJinpeng Cui <cui.jinpeng2@zte.com.cn>
Tue, 23 Aug 2022 12:29:14 +0000 (12:29 +0000)
committerDamien Le Moal <damien.lemoal@opensource.wdc.com>
Thu, 25 Aug 2022 22:46:08 +0000 (07:46 +0900)
Return value from ata_exec_internal() directly instead of
taking this in another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
drivers/ata/libata-core.c

index 864b260..0ba0e69 100644 (file)
@@ -4340,7 +4340,6 @@ static unsigned int ata_dev_set_xfermode(struct ata_device *dev)
 unsigned int ata_dev_set_feature(struct ata_device *dev, u8 subcmd, u8 action)
 {
        struct ata_taskfile tf;
-       unsigned int err_mask;
        unsigned int timeout = 0;
 
        /* set up set-features taskfile */
@@ -4356,9 +4355,8 @@ unsigned int ata_dev_set_feature(struct ata_device *dev, u8 subcmd, u8 action)
        if (subcmd == SETFEATURES_SPINUP)
                timeout = ata_probe_timeout ?
                          ata_probe_timeout * 1000 : SETFEATURES_SPINUP_TIMEOUT;
-       err_mask = ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, timeout);
 
-       return err_mask;
+       return ata_exec_internal(dev, &tf, NULL, DMA_NONE, NULL, 0, timeout);
 }
 EXPORT_SYMBOL_GPL(ata_dev_set_feature);