net: ipvlan: Issue NETDEV_PRE_CHANGEADDR
authorPetr Machata <petrm@mellanox.com>
Thu, 13 Dec 2018 11:54:41 +0000 (11:54 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 14 Dec 2018 02:41:38 +0000 (18:41 -0800)
A NETDEV_CHANGEADDR event implies a change of address of each of the
IPVLANs of this IPVLAN device. Therefore propagate NETDEV_PRE_CHANGEADDR
to all the IPVLANs.

Signed-off-by: Petr Machata <petrm@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ipvlan/ipvlan_main.c

index 723a3f6..19bdde6 100644 (file)
@@ -759,10 +759,13 @@ EXPORT_SYMBOL_GPL(ipvlan_link_register);
 static int ipvlan_device_event(struct notifier_block *unused,
                               unsigned long event, void *ptr)
 {
+       struct netlink_ext_ack *extack = netdev_notifier_info_to_extack(ptr);
+       struct netdev_notifier_pre_changeaddr_info *prechaddr_info;
        struct net_device *dev = netdev_notifier_info_to_dev(ptr);
        struct ipvl_dev *ipvlan, *next;
        struct ipvl_port *port;
        LIST_HEAD(lst_kill);
+       int err;
 
        if (!netif_is_ipvlan_port(dev))
                return NOTIFY_DONE;
@@ -818,6 +821,17 @@ static int ipvlan_device_event(struct notifier_block *unused,
                        ipvlan_adjust_mtu(ipvlan, dev);
                break;
 
+       case NETDEV_PRE_CHANGEADDR:
+               prechaddr_info = ptr;
+               list_for_each_entry(ipvlan, &port->ipvlans, pnode) {
+                       err = dev_pre_changeaddr_notify(ipvlan->dev,
+                                                   prechaddr_info->dev_addr,
+                                                   extack);
+                       if (err)
+                               return notifier_from_errno(err);
+               }
+               break;
+
        case NETDEV_CHANGEADDR:
                list_for_each_entry(ipvlan, &port->ipvlans, pnode) {
                        ether_addr_copy(ipvlan->dev->dev_addr, dev->dev_addr);