macintosh/adb: Use swap() to make code cleaner
authorYang Guang <yang.guang5@zte.com.cn>
Thu, 4 Nov 2021 01:14:56 +0000 (09:14 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 4 May 2022 09:37:45 +0000 (19:37 +1000)
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20211104011456.1027830-1-yang.guang5@zte.com.cn
drivers/macintosh/adbhid.c

index 1d355aa..b2fe7a3 100644 (file)
@@ -816,9 +816,7 @@ adbhid_input_register(int id, int default_id, int original_handler_id,
                case 0xC4: case 0xC7:
                        keyboard_type = "ISO, swapping keys";
                        input_dev->id.version = ADB_KEYBOARD_ISO;
-                       i = hid->keycode[10];
-                       hid->keycode[10] = hid->keycode[50];
-                       hid->keycode[50] = i;
+                       swap(hid->keycode[10], hid->keycode[50]);
                        break;
 
                case 0x12: case 0x15: case 0x16: case 0x17: case 0x1A: