misc: xilinx_sdfec: Prevent integer overflow in xsdfec_table_write()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 21 Aug 2019 07:11:22 +0000 (10:11 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Aug 2019 21:28:10 +0000 (14:28 -0700)
The checking here needs to handle integer overflows because "offset" and
"len" come from the user.

Fixes: 20ec628e8007 ("misc: xilinx_sdfec: Add ability to configure LDPC")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
Link: https://lore.kernel.org/r/20190821071122.GD26957@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/xilinx_sdfec.c

index 3fc53d2..0bf3bcc 100644 (file)
@@ -611,7 +611,9 @@ static int xsdfec_table_write(struct xsdfec_dev *xsdfec, u32 offset,
         * Writes that go beyond the length of
         * Shared Scale(SC) table should fail
         */
-       if ((XSDFEC_REG_WIDTH_JUMP * (offset + len)) > depth) {
+       if (offset > depth / XSDFEC_REG_WIDTH_JUMP ||
+           len > depth / XSDFEC_REG_WIDTH_JUMP ||
+           offset + len > depth / XSDFEC_REG_WIDTH_JUMP) {
                dev_dbg(xsdfec->dev, "Write exceeds SC table length");
                return -EINVAL;
        }