ARM: shmobile: rcar-gen2: Fix error check in regulator quirk
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 28 Feb 2018 09:13:00 +0000 (10:13 +0100)
committerSimon Horman <horms+renesas@verge.net.au>
Wed, 28 Feb 2018 13:25:49 +0000 (14:25 +0100)
On systems with two regulators, a bogus error message is printed on
success:

    i2c 6-0058: i2c error 2

While adding support for Stout, the number of messages to send was
made variable, but the corresponding return value check of
i2c_transfer() wasn't updated.

Fixes: ff938cd14d67a704 ("ARM: shmobile: stout: enable R-Car Gen2 regulator quirk")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c

index 27fb3a5..93f628a 100644 (file)
@@ -98,7 +98,7 @@ static int regulator_quirk_notify(struct notifier_block *nb,
 
                dev_info(&client->dev, "clearing da9063/da9210 interrupts\n");
                ret = i2c_transfer(client->adapter, da9xxx_msgs, len);
-               if (ret != ARRAY_SIZE(da9xxx_msgs))
+               if (ret != len)
                        dev_err(&client->dev, "i2c error %d\n", ret);
        }