net: atm: Reduce the severity of logging in unlink_clip_vcc
authorAditya Pakki <pakki001@umn.edu>
Sun, 17 Nov 2019 20:28:36 +0000 (14:28 -0600)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Nov 2019 01:08:20 +0000 (17:08 -0800)
In case of errors in unlink_clip_vcc, the logging level is set to
pr_crit but failures in clip_setentry are handled by pr_err().
The patch changes the severity consistent across invocations.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/atm/clip.c

index a7972da..294cb9e 100644 (file)
@@ -89,7 +89,7 @@ static void unlink_clip_vcc(struct clip_vcc *clip_vcc)
        struct clip_vcc **walk;
 
        if (!entry) {
-               pr_crit("!clip_vcc->entry (clip_vcc %p)\n", clip_vcc);
+               pr_err("!clip_vcc->entry (clip_vcc %p)\n", clip_vcc);
                return;
        }
        netif_tx_lock_bh(entry->neigh->dev);    /* block clip_start_xmit() */
@@ -109,10 +109,10 @@ static void unlink_clip_vcc(struct clip_vcc *clip_vcc)
                        error = neigh_update(entry->neigh, NULL, NUD_NONE,
                                             NEIGH_UPDATE_F_ADMIN, 0);
                        if (error)
-                               pr_crit("neigh_update failed with %d\n", error);
+                               pr_err("neigh_update failed with %d\n", error);
                        goto out;
                }
-       pr_crit("ATMARP: failed (entry %p, vcc 0x%p)\n", entry, clip_vcc);
+       pr_err("ATMARP: failed (entry %p, vcc 0x%p)\n", entry, clip_vcc);
 out:
        netif_tx_unlock_bh(entry->neigh->dev);
 }