[mlir][gpu] Fix build failure / silence windows build warnings
authorChristopher Bate <cbate@nvidia.com>
Fri, 13 Jan 2023 20:23:56 +0000 (13:23 -0700)
committerChristopher Bate <cbate@nvidia.com>
Fri, 13 Jan 2023 20:40:57 +0000 (13:40 -0700)
Fixes Windows build failure (C4715) caused by
6ca1a09f03e8e940f306bea73efa935e4ee38173.

mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp
mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp

index f3cf780..40fd952 100644 (file)
@@ -206,6 +206,8 @@ struct LowerGpuOpsToNVVMOpsPass
             case gpu::AddressSpace::Private:
               return 0;
             }
+            llvm_unreachable("unknown address space enum value");
+            return 0;
           });
       gpu::populateMemorySpaceLoweringPatterns(typeConverter, patterns);
       ConversionTarget target(getContext());
index 25571bd..034188f 100644 (file)
@@ -146,6 +146,8 @@ struct LowerGpuOpsToROCDLOpsPass
             case gpu::AddressSpace::Private:
               return 5;
             }
+            llvm_unreachable("unknown address space enum value");
+            return 0;
           });
       ConversionTarget target(getContext());
       gpu::populateLowerMemorySpaceOpLegality(target);