IB/hfi1: Simplify init_qpmap_table()
authorDean Luick <dean.luick@intel.com>
Tue, 12 Apr 2016 17:50:35 +0000 (10:50 -0700)
committerDoug Ledford <dledford@redhat.com>
Thu, 28 Apr 2016 20:32:27 +0000 (16:32 -0400)
Make init_qpmap_table() easier to understand by simplifying
the loop indexing and writing each register when it is "full",
removing the need for a follow-on register write.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Dean Luick <dean.luick@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/staging/rdma/hfi1/chip.c

index 79dc29a..56753c6 100644 (file)
@@ -13451,20 +13451,17 @@ static void init_qpmap_table(struct hfi1_devdata *dd,
        int i;
        u64 ctxt = first_ctxt;
 
-       for (i = 0; i < 256;) {
+       for (i = 0; i < 256; i++) {
                reg |= ctxt << (8 * (i % 8));
-               i++;
                ctxt++;
                if (ctxt > last_ctxt)
                        ctxt = first_ctxt;
-               if (i % 8 == 0) {
+               if (i % 8 == 7) {
                        write_csr(dd, regno, reg);
                        reg = 0;
                        regno += 8;
                }
        }
-       if (i % 8)
-               write_csr(dd, regno, reg);
 
        add_rcvctrl(dd, RCV_CTRL_RCV_QP_MAP_ENABLE_SMASK
                        | RCV_CTRL_RCV_BYPASS_ENABLE_SMASK);