mfd: stmfx: Fix stmfx_irq_init error path

In case the interrupt signal can't be configured, IRQ domain needs to be
removed.

Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver")
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>

diff --git a/drivers/mfd/stmfx.c b/drivers/mfd/stmfx.c
index fde6541..1977fe9 100644 (file)
--- a/drivers/mfd/stmfx.c
+++ b/drivers/mfd/stmfx.c
@@ -287,14 +287,19 @@ static int stmfx_irq_init(struct i2c_client *client)
 
        ret = regmap_write(stmfx->map, STMFX_REG_IRQ_OUT_PIN, irqoutpin);
        if (ret)
-               return ret;
+               goto irq_exit;
 
        ret = devm_request_threaded_irq(stmfx->dev, client->irq,
                                        NULL, stmfx_irq_handler,
                                        irqtrigger | IRQF_ONESHOT,
                                        "stmfx", stmfx);
        if (ret)
-               stmfx_irq_exit(client);
+               goto irq_exit;
+
+       return 0;
+
+irq_exit:
+       stmfx_irq_exit(client);
 
        return ret;
 }