mtd: rawnand: meson: Add of_node_put() before return
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Tue, 9 Jul 2019 17:16:40 +0000 (22:46 +0530)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 25 Jul 2019 12:21:44 +0000 (14:21 +0200)
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Acked-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/meson_nand.c

index ea57ddc..1b82b68 100644 (file)
@@ -1320,6 +1320,7 @@ static int meson_nfc_nand_chips_init(struct device *dev,
                ret = meson_nfc_nand_chip_init(dev, nfc, nand_np);
                if (ret) {
                        meson_nfc_nand_chip_cleanup(nfc);
+                       of_node_put(nand_np);
                        return ret;
                }
        }