Fix static analysis 65/224365/2
authorInkyun Kil <inkyun.kil@samsung.com>
Mon, 10 Feb 2020 06:25:13 +0000 (15:25 +0900)
committerInkyun Kil <inkyun.kil@samsung.com>
Mon, 10 Feb 2020 06:28:24 +0000 (15:28 +0900)
Change-Id: I810a27eaf80ad5478f098f0f241232f8ba97c3f3
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
server/alarm-manager-db.c

index eda1a77..1b63b77 100644 (file)
@@ -248,6 +248,11 @@ bool _save_alarms(__alarm_info_t *__alarm_info)
                        CHECK_NULL_STRING(__alarm_info->dst_service_name),
                        CHECK_NULL_STRING(__alarm_info->dst_service_name_mod));
 
+       if (!query) {
+               LOGE("Failed to alloc query");
+               return false;
+       }
+
        if (SQLITE_OK != sqlite3_exec(alarmmgr_db, query, NULL, NULL, &error_message)) {
                SECURE_LOGE("sqlite3_exec() is failed. query = %s, error message = %s", query, error_message);
                sqlite3_free(error_message);
@@ -300,6 +305,11 @@ bool _update_alarms(__alarm_info_t *__alarm_info)
                        CHECK_NULL_STRING(__alarm_info->dst_service_name_mod),
                        __alarm_info->alarm_id);
 
+       if (!query) {
+               LOGE("Failed to alloc query");
+               return false;
+       }
+
        if (SQLITE_OK != sqlite3_exec(alarmmgr_db, query, NULL, NULL, &error_message)) {
                SECURE_LOGE("sqlite3_exec() is failed. query = %s, error message = %s", query, error_message);
                sqlite3_free(error_message);
@@ -316,6 +326,11 @@ bool _delete_alarms(alarm_id_t alarm_id)
        char *error_message = NULL;
        char *query = sqlite3_mprintf("delete from alarmmgr where alarm_id=%d", alarm_id);
 
+       if (!query) {
+               LOGE("Failed to alloc query");
+               return false;
+       }
+
        if (SQLITE_OK != sqlite3_exec(alarmmgr_db, query, NULL, NULL, &error_message)) {
                SECURE_LOGE("sqlite3_exec() is failed. query = %s, error message = %s", query, error_message);
                sqlite3_free(error_message);
@@ -539,6 +554,11 @@ int _get_db_path_for_all_info(uid_t uid, char** db_path)
                                mode->repeat,
                                entry->base_info.alarm_type);
 
+               if (!query) {
+                       LOGE("Failed to alloc query");
+                       return ERR_ALARM_SYSTEM_FAIL;
+               }
+
                if (sqlite3_exec(alarmmgr_tool_db, query, NULL, NULL, &error_message) != SQLITE_OK) {
                        SECURE_LOGE("sqlite3_exec() is failed. error message = %s", error_message);
                        sqlite3_free(error_message);
@@ -586,6 +606,11 @@ bool _alarm_set_global_to_db(__alarm_info_t *alarm_info, bool global)
        char *query = sqlite3_mprintf("update alarmmgr set global=%d where alarm_id=%d",
                        alarm_info->global, alarm_info->alarm_id);
 
+       if (!query) {
+               LOGE("Failed to alloc query");
+               return false;
+       }
+
        if (SQLITE_OK != sqlite3_exec(alarmmgr_db, query, NULL, NULL, &error_message)) {
                SECURE_LOGE("sqlite3_exec() is failed. query = %s, error message = %s", query, error_message);
                sqlite3_free(query);
@@ -604,6 +629,11 @@ void _update_db_for_disabled_alarm(alarm_id_t alarm_id, bool disabled)
        LOGW("Update (%d) is_disabled to (%d)", alarm_id, disabled);
        char *query = sqlite3_mprintf("update alarmmgr set is_disabled=%d where alarm_id=%d", disabled, alarm_id);
 
+       if (!query) {
+               LOGE("Failed to alloc query");
+               return;
+       }
+
        if (SQLITE_OK != sqlite3_exec(alarmmgr_db, query, NULL, NULL, &error_message)) {
                SECURE_LOGE("Failed to update the DB table. error message = %s", error_message);
                sqlite3_free(error_message);