Replace pointer to smart pointer for RAII

Change-Id: I1f987e62ff3b6284151aeec562c41d743610f267

diff --git a/srcs/client/client-request.h b/srcs/client/client-request.h
index cc5f86c886b9703d7506ef772e98356ea9fde69f..b655a7efba1ab2c0066227ccb50ddc7050b3ed66 100644 (file)
--- a/srcs/client/client-request.h
+++ b/srcs/client/client-request.h
@@ -36,22 +36,20 @@ namespace WA {
 
 class ClientRequest {
 public:
-    explicit ClientRequest(WebAuthnCall action)
+    explicit ClientRequest(WebAuthnCall action) : 
+        m_action(action),
+        m_conn(std::make_unique<Connection>())
     {
-        m_conn = new Connection();
         int ret = m_conn->createConnect(SERVICE_SOCKET);
         if (ret != WAUTHN_ERROR_NONE)
             ThrowMsg(ServiceException::InActive, "Error in createConnect");
         m_buffer.InitForStreaming();
-        Serialization::Serialize(m_buffer, static_cast<int>(action));
-        LogDebug("ClientRequest " << WebAuthnCallToString(action));
+        Serialization::Serialize(m_buffer, static_cast<int>(m_action));
+        LogDebug("ClientRequest " << WebAuthnCallToString(m_action));
     }
 
     ~ClientRequest()
-    {
-        if(!m_conn)
-            delete m_conn;
-    }
+    {}
 
     int getStatus() const
     {
@@ -141,7 +139,8 @@ private:
     bool m_sent = false;
     int m_status = WAUTHN_ERROR_NONE;
     MessageBuffer m_buffer;
-    Connection *m_conn = nullptr;
+    WebAuthnCall m_action;
+    std::unique_ptr<Connection> m_conn;
 };
 
 } // namespace WebAuthn