ASoC: don't indicate error message for snd_soc_[pcm_]component_xxx()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Mon, 15 Mar 2021 00:58:41 +0000 (09:58 +0900)
committerMark Brown <broonie@kernel.org>
Fri, 19 Mar 2021 12:24:05 +0000 (12:24 +0000)
All snd_soc_component_xxx() and snd_soc_pcm_component_xxx() itself
indicate error message if failed.
Its caller doesn't need to indicate duplicated error message.
This patch removes it.

All snd_soc_component_xxx() indicate error message if failed.
Its caller doesn't need to indicate duplicated error message.
This patch removes it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/878s6puta6.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-core.c
sound/soc/soc-pcm.c

index f12c763..522bae7 100644 (file)
@@ -1203,11 +1203,9 @@ static int soc_probe_component(struct snd_soc_card *card,
        }
 
        ret = snd_soc_component_probe(component);
-       if (ret < 0) {
-               dev_err(component->dev,
-                       "ASoC: failed to probe component %d\n", ret);
+       if (ret < 0)
                goto err_probe;
-       }
+
        WARN(dapm->idle_bias_off &&
             dapm->bias_level != SND_SOC_BIAS_OFF,
             "codec %s can not start from non-off bias with idle_bias_off==1\n",
index ecf2bfa..2df70ab 100644 (file)
@@ -2781,11 +2781,8 @@ int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num)
                snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_CAPTURE, &rtd->ops);
 
        ret = snd_soc_pcm_component_new(rtd);
-       if (ret < 0) {
-               dev_err(rtd->dev, "ASoC: pcm constructor failed for dailink %s: %d\n",
-                       rtd->dai_link->name, ret);
+       if (ret < 0)
                return ret;
-       }
 
        pcm->no_device_suspend = true;
 out: