media: pt3: remove redundant assignment to mask
authorColin Ian King <colin.king@canonical.com>
Tue, 31 Oct 2017 10:19:42 +0000 (06:19 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 8 Dec 2017 15:11:22 +0000 (10:11 -0500)
Variable mask is being set to 0x80 and then set to this value again
in the following for-loop. Remove the extraneous first setting of mask.
Cleans up clang warning:

drivers/media/pci/pt3/pt3_i2c.c:88:2: warning: Value stored to 'mask'
is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/pt3/pt3_i2c.c

index ec6a8a2..b66138c 100644 (file)
@@ -85,7 +85,6 @@ static void put_byte_write(struct pt3_i2cbuf *cbuf, u8 val)
 {
        u8 mask;
 
-       mask = 0x80;
        for (mask = 0x80; mask > 0; mask >>= 1)
                cmdbuf_add(cbuf, (val & mask) ? I_DATA_H_NOP : I_DATA_L_NOP);
        cmdbuf_add(cbuf, I_DATA_H_ACK0);