io_uring: use io_file_from_index in __io_sync_cancel
authorChristoph Hellwig <hch@lst.de>
Tue, 20 Jun 2023 11:32:33 +0000 (13:32 +0200)
committerJens Axboe <axboe@kernel.dk>
Tue, 20 Jun 2023 15:36:22 +0000 (09:36 -0600)
Use io_file_from_index instead of open coding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20230620113235.920399-7-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/cancel.c

index b4f5dfa..58c46c8 100644 (file)
@@ -216,13 +216,10 @@ static int __io_sync_cancel(struct io_uring_task *tctx,
        /* fixed must be grabbed every time since we drop the uring_lock */
        if ((cd->flags & IORING_ASYNC_CANCEL_FD) &&
            (cd->flags & IORING_ASYNC_CANCEL_FD_FIXED)) {
-               unsigned long file_ptr;
-
                if (unlikely(fd >= ctx->nr_user_files))
                        return -EBADF;
                fd = array_index_nospec(fd, ctx->nr_user_files);
-               file_ptr = io_fixed_file_slot(&ctx->file_table, fd)->file_ptr;
-               cd->file = (struct file *) (file_ptr & FFS_MASK);
+               cd->file = io_file_from_index(&ctx->file_table, fd);
                if (!cd->file)
                        return -EBADF;
        }