libstdc++: Fix std::jthread assertion and re-enable skipped test
authorJonathan Wakely <jwakely@redhat.com>
Mon, 17 May 2021 13:55:22 +0000 (14:55 +0100)
committerJonathan Wakely <jwakely@redhat.com>
Mon, 17 May 2021 16:56:57 +0000 (17:56 +0100)
libstdc++-v3/ChangeLog:

* include/std/thread (jthread::_S_create): Fix static assert
message.
* testsuite/30_threads/jthread/95989.cc: Re-enable test.
* testsuite/30_threads/jthread/jthread.cc: Do not require
pthread effective target.
* testsuite/30_threads/jthread/2.cc: Moved to...
* testsuite/30_threads/jthread/version.cc: ...here.

libstdc++-v3/include/std/thread
libstdc++-v3/testsuite/30_threads/jthread/95989.cc
libstdc++-v3/testsuite/30_threads/jthread/jthread.cc
libstdc++-v3/testsuite/30_threads/jthread/version.cc [moved from libstdc++-v3/testsuite/30_threads/jthread/2.cc with 100% similarity]

index 886994c..f51392a 100644 (file)
@@ -219,7 +219,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
          {
            static_assert(is_invocable_v<decay_t<_Callable>,
                                         decay_t<_Args>...>,
-                         "std::thread arguments must be invocable after"
+                         "std::jthread arguments must be invocable after"
                          " conversion to rvalues");
            return thread{std::forward<_Callable>(__f),
                          std::forward<_Args>(__args)...};
index 53f9082..fb3f43b 100644 (file)
@@ -20,7 +20,6 @@
 // { dg-require-gthreads {} }
 // { dg-additional-options "-pthread" { target pthread } }
 // { dg-additional-options "-static" { target static } }
-// { dg-skip-if "broken" { *-*-* } }
 
 #include <thread>
 
index 6adc498..7997870 100644 (file)
@@ -16,9 +16,9 @@
 // <http://www.gnu.org/licenses/>.
 
 // { dg-options "-std=gnu++2a -pthread" }
-// { dg-add-options libatomic }
 // { dg-do run { target c++2a } }
-// { dg-require-effective-target pthread }
+// { dg-add-options libatomic }
+// { dg-additional-options "-pthread" { target pthread } }
 // { dg-require-gthreads "" }
 
 #include <thread>