PCI: versatile: Remove redundant variable retval
authorColin Ian King <colin.i.king@gmail.com>
Mon, 18 Apr 2022 14:44:16 +0000 (15:44 +0100)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Thu, 28 Apr 2022 09:46:37 +0000 (10:46 +0100)
Variable retval is being assigned a value that is never read, the
variable is redundant and can be removed.

Cleans up clang scan build warning:
drivers/pci/controller/pci-versatile.c:37:10: warning: Although the value
stored to 'retval' is used in the enclosing expression, the value is never
actually read from 'retval' [deadcode.DeadStores]

Link: https://lore.kernel.org/r/20220418144416.86121-1-colin.i.king@gmail.com
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
drivers/pci/controller/pci-versatile.c

index 653d5d0..7991d33 100644 (file)
@@ -31,10 +31,9 @@ static u32 pci_slot_ignore;
 
 static int __init versatile_pci_slot_ignore(char *str)
 {
-       int retval;
        int slot;
 
-       while ((retval = get_option(&str, &slot))) {
+       while (get_option(&str, &slot)) {
                if ((slot < 0) || (slot > 31))
                        pr_err("Illegal slot value: %d\n", slot);
                else