Input: zxt_ztm620_ts: Repalce meaningless strncat() to strcat() 19/220819/2
authorSeung-Woo Kim <sw0312.kim@samsung.com>
Mon, 23 Dec 2019 10:01:44 +0000 (19:01 +0900)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Fri, 27 Dec 2019 01:57:22 +0000 (10:57 +0900)
The strncat() with length from strlen() of copied string is
completely meaningless. Just replace the usage of strncat() to
strcat().

Change-Id: Ibdd75a6cc7d5e2f9e80f20535f7d61b278fc29a3
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
drivers/input/touchscreen/zxt_ztm620_ts.c

index 77517ce930aeade6851b8def6bdef38bb561a373..f4d396469fb3b7b1a533ba5455fbe565365df911 100644 (file)
@@ -555,10 +555,10 @@ static void ztm620_store_raw_data(struct ztm620_info *info)
        memset(buff, 0x0, FILE_BUFF_SIZE);
        for (i = 0; i < (total_node + 32); i++) {
                sprintf(tmp, "%05d\t", info->cur_data[i]);
-               strncat(buff, tmp, strlen(tmp));
+               strcat(buff, tmp);
        }
        sprintf(tmp, "\n");
-       strncat(buff, tmp, strlen(tmp));
+       strcat(buff, tmp);
        vfs_write(fp, (char __user *)buff, (total_node+32)*6+1, &fp->f_pos);
        filp_close(fp, current->files);
        set_fs(old_fs);
@@ -2453,7 +2453,7 @@ static inline void set_default_result(struct tsp_factory_info *finfo)
 {
        char delim = ':';
        memset(finfo->cmd_result, 0x00, ARRAY_SIZE(finfo->cmd_result));
-       strncat(finfo->cmd_result, finfo->cmd, strlen(finfo->cmd));
+       strcat(finfo->cmd_result, finfo->cmd);
        strncat(finfo->cmd_result, &delim, 1);
 }
 
@@ -3496,9 +3496,9 @@ static void get_ssr_read(void *device_data)
 
        for (j = 0; j < y_num; j++) {
                sprintf(tmp, "%d",  raw_data->ssr_data[j]);
-               strncat(finfo->cmd_buff, tmp, strlen(tmp));
+               strcat(finfo->cmd_buff, tmp);
                if (j < y_num-1)
-                       strncat(finfo->cmd_buff, " ", strlen(" "));
+                       strcat(finfo->cmd_buff, " ");
        }
 
        set_cmd_result(finfo, finfo->cmd_buff,
@@ -3580,9 +3580,9 @@ static void get_sfr_read(void *device_data)
 
        for (j = 0; j < y_num; j++) {
                sprintf(tmp, "%d",  raw_data->sfr_data[j]);
-               strncat(finfo->cmd_buff, tmp, strlen(tmp));
+               strcat(finfo->cmd_buff, tmp);
                if (j < y_num-1)
-                       strncat(finfo->cmd_buff, " ", strlen(" "));
+                       strcat(finfo->cmd_buff, " ");
        }
 
        set_cmd_result(finfo, finfo->cmd_buff,
@@ -3678,9 +3678,9 @@ static void get_sfr_h_gap_read(void *device_data)
 
        for (j = 0; j < (y_num - 1); j++) {
                sprintf(tmp, "%d",  raw_data->sfr_hgap_data[j]);
-               strncat(finfo->cmd_buff, tmp, strlen(tmp));
+               strcat(finfo->cmd_buff, tmp);
                if (j < (y_num-2))
-                       strncat(finfo->cmd_buff, " ", strlen(" "));
+                       strcat(finfo->cmd_buff, " ");
        }
 
        set_cmd_result(finfo, finfo->cmd_buff,
@@ -3772,9 +3772,9 @@ static void get_trx_short_read(void *device_data)
 
        for (j = 0; j < doubel_y_num; j++) {
                sprintf(tmp, "%d",  raw_data->trxshort_data[j]);
-               strncat(finfo->cmd_buff, tmp, strlen(tmp));
+               strcat(finfo->cmd_buff, tmp);
                if (j < doubel_y_num-1)
-                       strncat(finfo->cmd_buff, " ", strlen(" "));
+                       strcat(finfo->cmd_buff, " ");
        }
 
        set_cmd_result(finfo, finfo->cmd_buff,
@@ -3869,9 +3869,9 @@ static void get_dnd(void *device_data)
 
        for (i=0; i < y_num; i++) {
                sprintf(tmp, "%d",  raw_data->dnd_data[i + (y_num * y_node)]);
-               strncat(finfo->cmd_buff, tmp, strlen(tmp));
+               strcat(finfo->cmd_buff, tmp);
                if (i < y_num-1)
-                       strncat(finfo->cmd_buff, " ", strlen(" "));
+                       strcat(finfo->cmd_buff, " ");
        }
 
        set_cmd_result(finfo, finfo->cmd_buff,
@@ -4039,9 +4039,9 @@ static void get_dnd_h_gap(void *device_data)
 
        for (i=0; i < y_num-1; i++) {
                sprintf(tmp, "%d",  raw_data->hgap_data[i + (y_num * y_node)]);
-               strncat(finfo->cmd_buff, tmp, strlen(tmp));
+               strcat(finfo->cmd_buff, tmp);
                if (i < y_num-1)
-                       strncat(finfo->cmd_buff, " ", strlen(" "));
+                       strcat(finfo->cmd_buff, " ");
        }
 
        set_cmd_result(finfo, finfo->cmd_buff,
@@ -4076,9 +4076,9 @@ static void get_dnd_v_gap(void *device_data)
 
        for (i=0; i < y_num; i++) {
                sprintf(tmp, "%d",  raw_data->vgap_data[i + (y_num * y_node)]);
-               strncat(finfo->cmd_buff, tmp, strlen(tmp));
+               strcat(finfo->cmd_buff, tmp);
                if (i < y_num-1)
-                       strncat(finfo->cmd_buff, " ", strlen(" "));
+                       strcat(finfo->cmd_buff, " ");
        }
 
        set_cmd_result(finfo, finfo->cmd_buff,
@@ -4171,9 +4171,9 @@ static void get_hfdnd(void *device_data)
 
        for (i=0; i < y_num; i++) {
                sprintf(tmp, "%d",  raw_data->hfdnd_data[i + (y_num * y_node)]);
-               strncat(finfo->cmd_buff, tmp, strlen(tmp));
+               strcat(finfo->cmd_buff, tmp);
                if (i < y_num-1)
-                       strncat(finfo->cmd_buff, " ", strlen(" "));
+                       strcat(finfo->cmd_buff, " ");
        }
 
        set_cmd_result(finfo, finfo->cmd_buff,
@@ -4265,9 +4265,9 @@ static void get_hfdnd_v_gap(void *device_data)
 
        for (i=0; i < y_num; i++) {
                sprintf(tmp, "%d",  raw_data->hfvgap_data[i + (y_num * y_node)]);
-               strncat(finfo->cmd_buff, tmp, strlen(tmp));
+               strcat(finfo->cmd_buff, tmp);
                if (i < y_num-1)
-                       strncat(finfo->cmd_buff, " ", strlen(" "));
+                       strcat(finfo->cmd_buff, " ");
        }
 
        set_cmd_result(finfo, finfo->cmd_buff,
@@ -4366,9 +4366,9 @@ static void get_hfdnd_h_gap(void *device_data)
 
        for (i=0; i < y_num-1; i++) {
                sprintf(tmp, "%d",  raw_data->hfhgap_data[i + (y_num * y_node)]);
-               strncat(finfo->cmd_buff, tmp, strlen(tmp));
+               strcat(finfo->cmd_buff, tmp);
                if (i < y_num-1)
-                       strncat(finfo->cmd_buff, " ", strlen(" "));
+                       strcat(finfo->cmd_buff, " ");
        }
 
        set_cmd_result(finfo, finfo->cmd_buff,
@@ -5360,14 +5360,14 @@ static ssize_t ztm620_show_raw_check(struct device *dev, struct device_attribute
 check_print:
        for ( i = 0, ret = 0; i < info->cap_info.x_node_num * info->cap_info.y_node_num; i++) {
                if ((i !=0) && !(i%info->cap_info.x_node_num)) {
-                       strncat(buf, "\n", strlen("\n"));
+                       strcat(buf, "\n");
                        ret += strlen("\n");
                }
 
                ret += sprintf(cat_buf, "%04d, ", read_buf[i]);
-               strncat(buf, cat_buf, strlen(cat_buf));
+               strcat(buf, cat_buf);
        }
-       strncat(buf, "\n\n", strlen("\n\n"));
+       strcat(buf, "\n\n");
        ret += strlen("\n\n");
 
        return ret;