ide: Use a flag for an ATAPI device
authorSimon Glass <sjg@chromium.org>
Fri, 12 Aug 2022 01:34:53 +0000 (19:34 -0600)
committerTom Rini <trini@konsulko.com>
Fri, 16 Sep 2022 15:05:16 +0000 (11:05 -0400)
Rather than setting a different interface type, use a flag to indicate
that a device is ATAPI.

Signed-off-by: Simon Glass <sjg@chromium.org>
drivers/block/ide.c

index 3270a9f..6bc48e3 100644 (file)
@@ -525,8 +525,8 @@ static void ide_ident(struct blk_desc *dev_desc)
 {
        unsigned char c;
        hd_driveid_t iop;
-
 #ifdef CONFIG_ATAPI
+       bool is_atapi = false;
        int retries = 0;
 #endif
        int device;
@@ -550,7 +550,7 @@ static void ide_ident(struct blk_desc *dev_desc)
                    (ide_inb(device, ATA_CYL_LOW) == 0x14) &&
                    (ide_inb(device, ATA_CYL_HIGH) == 0xEB)) {
                        /* ATAPI Signature found */
-                       dev_desc->if_type = IF_TYPE_ATAPI;
+                       is_atapi = true;
                        /*
                         * Start Ident Command
                         */
@@ -623,7 +623,7 @@ static void ide_ident(struct blk_desc *dev_desc)
                dev_desc->removable = 0;
 
 #ifdef CONFIG_ATAPI
-       if (dev_desc->if_type == IF_TYPE_ATAPI) {
+       if (is_atapi) {
                atapi_inquiry(dev_desc);
                return;
        }