atspi: suppress runtime error, build warning 97/167197/5
authorJunsuChoi <jsuya.choi@samsung.com>
Tue, 16 Jan 2018 06:42:54 +0000 (15:42 +0900)
committerGerrit Code Review <gerrit@review.ap-northeast-2.compute.internal>
Wed, 17 Jan 2018 03:53:18 +0000 (03:53 +0000)
   [runtime error]
   (1) elm_atspi_bridge.c:2787 _bridge_path_from_object() safety check failed: eo == NULL
   (2) elm_atspi_bridge.c:6184 _bridge_object_register() Unable to register class w/o Elm_Interface_Atspi_Accessible!
   (3) lib/eo/eo.c:697 _eo_call_resolve() in elm_widget.eo.c:169: func 'elm_obj_widget_access_highlight_in_theme_get' (288) could not be resolved for class 'Edje_Object'

   - Note: The access_highlight_in_theme (3) should handle non Elm_LAYOUT_CLASS.
     Or the access_highlight_in_theme should be removed. If the screen-reader
     shows highlight, then the access_highlight_in_theme doesn't make sense.

   [build warning]
   (1) warning: passing argument 2 of '_object_get_bus_name_and_path' discards 'const' qualifier from pointer target type
   (2) warning: passing argument 3 of '_object_get_bus_name_and_path' from incompatible pointer type

Change-Id: I5dbeabf1224dbfdd17fd2d1eb9d72bfff120ccab

src/lib/elementary/elm_atspi_bridge.c

index c19afeb..a19240b 100644 (file)
@@ -1114,7 +1114,7 @@ _accessible_get_navigable_at_point(const Eldbus_Service_Interface *iface EINA_UN
 
    /* Send deputy */
    _bridge_iter_object_reference_append(bridge, iter, deputy);
-   _bridge_object_register(bridge, deputy);
+   if (deputy) _bridge_object_register(bridge, deputy);
 
    return ret;
 }
@@ -1328,7 +1328,11 @@ _accessible_reading_material_get(const Eldbus_Service_Interface *iface, const El
 
    /* is selected in parent */
    parent = efl_access_parent_get(obj);
-   is_selected = efl_access_selection_is_child_selected(parent, idx);
+   if (efl_isa(parent, EFL_ACCESS_SELECTION_INTERFACE))
+     {
+        is_selected = efl_access_selection_is_child_selected(parent, idx);
+     }
+
    eldbus_message_arguments_append(ret, "b", is_selected);
 
    /* has checkbox child */