i2c: qcom-cci: Use dev_err_probe in probe function
authorLiao Chang <liaochang1@huawei.com>
Tue, 8 Aug 2023 01:29:50 +0000 (09:29 +0800)
committerAndi Shyti <andi.shyti@kernel.org>
Thu, 10 Aug 2023 08:13:24 +0000 (10:13 +0200)
Use the dev_err_probe function instead of dev_err in the probe function
so that the printed message includes the return value and also handles
-EPROBE_DEFER nicely.

Signed-off-by: Liao Chang <liaochang1@huawei.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20230808012954.1643834-6-liaochang1@huawei.com
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-qcom-cci.c

index 622dc14..cf13abe 100644 (file)
@@ -588,10 +588,8 @@ static int cci_probe(struct platform_device *pdev)
        /* Clocks */
 
        ret = devm_clk_bulk_get_all(dev, &cci->clocks);
-       if (ret < 1) {
-               dev_err(dev, "failed to get clocks %d\n", ret);
-               return ret;
-       }
+       if (ret < 1)
+               return dev_err_probe(dev, ret, "failed to get clocks\n");
        cci->nclocks = ret;
 
        /* Retrieve CCI clock rate */