projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c7d7d4e
)
ASoC: max98373: Add checks for devm_kcalloc
author
Jiasheng Jiang
<jiasheng@iscas.ac.cn>
Wed, 16 Nov 2022 08:25:08 +0000
(16:25 +0800)
committer
Mark Brown
<broonie@kernel.org>
Wed, 16 Nov 2022 10:50:12 +0000
(10:50 +0000)
As the devm_kcalloc may return NULL pointer,
it should be better to check the return value
in order to avoid NULL poineter dereference.
Fixes:
349dd23931d1
("ASoC: max98373: don't access volatile registers in bias level off")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link:
https://lore.kernel.org/r/20221116082508.17418-1-jiasheng@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/max98373-i2c.c
patch
|
blob
|
history
diff --git
a/sound/soc/codecs/max98373-i2c.c
b/sound/soc/codecs/max98373-i2c.c
index
3e04c7f
..
ec0905d
100644
(file)
--- a/
sound/soc/codecs/max98373-i2c.c
+++ b/
sound/soc/codecs/max98373-i2c.c
@@
-549,6
+549,10
@@
static int max98373_i2c_probe(struct i2c_client *i2c)
max98373->cache = devm_kcalloc(&i2c->dev, max98373->cache_num,
sizeof(*max98373->cache),
GFP_KERNEL);
+ if (!max98373->cache) {
+ ret = -ENOMEM;
+ return ret;
+ }
for (i = 0; i < max98373->cache_num; i++)
max98373->cache[i].reg = max98373_i2c_cache_reg[i];