2010-12-27 Yael Aharon <yael.aharon@nokia.com>

        Reviewed by Eric Seidel.

        Browser is failing 16 baseline test from Selector API Test Suite
        https://bugs.webkit.org/show_bug.cgi?id=42968

        Update the expected result for the test.

        * fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt:
2010-12-27  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Eric Seidel.

        Browser is failing 16 baseline test from Selector API Test Suite
        https://bugs.webkit.org/show_bug.cgi?id=42968

        Throw an exception if there is no argument to querySelector or
        querySelectorAll. This replaces the current behavior of passing the string
        "undefined" as the argument.

        No new tests, just updating the existing results for
        fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.

        * dom/Document.idl:
        * dom/DocumentFragment.idl:
        * dom/Element.idl:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 37b34bc..aa2dec1 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2010-12-27  Yael Aharon  <yael.aharon@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        Browser is failing 16 baseline test from Selector API Test Suite
+        https://bugs.webkit.org/show_bug.cgi?id=42968
+
+        Update the expected result for the test.
+
+        * fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt:
+
 2010-12-27  Shinichiro Hamaji  <shinichiro.hamaji@gmail.com>
 
         Chromium expectation update.

diff --git a/LayoutTests/fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt b/LayoutTests/fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt
index 65ecc33..58e058e 100644 (file)
--- a/LayoutTests/fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt
+++ b/LayoutTests/fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt
@@ -4,17 +4,17 @@ Testrunner by John Resig, tests by John Resig, Disruptive Innovations, W3C CSS W
 
  Show only failing tests.
 
-99.2%: 2147 passed, 17 failed
+100.0%: 2163 passed, 1 failed
 PASS Element supports querySelector
 PASS Element supports querySelectorAll
 PASS Element.querySelectorAll Empty String
 PASS Element.querySelectorAll null
 PASS Element.querySelectorAll undefined
-FAIL Element.querySelectorAll no value
+PASS Element.querySelectorAll no value
 PASS Element.querySelector Empty String
 PASS Element.querySelector null
 PASS Element.querySelector undefined
-FAIL Element.querySelector no value
+PASS Element.querySelector no value
 PASS Element.querySelectorAll: .target :target
 PASS Element.querySelectorAll Whitespace Trim: .target :target
 PASS Element.querySelector: .target :target
@@ -550,11 +550,11 @@ PASS Outside Element: + combinator
 PASS Syntax Error: Element.querySelectorAll Empty String
 PASS Syntax Error: Element.querySelectorAll null
 PASS Syntax Error: Element.querySelectorAll undefined
-FAIL Syntax Error: Element.querySelectorAll no value
+PASS Syntax Error: Element.querySelectorAll no value
 PASS Syntax Error: Element.querySelector Empty String
 PASS Syntax Error: Element.querySelector null
 PASS Syntax Error: Element.querySelector undefined
-FAIL Syntax Error: Element.querySelector no value
+PASS Syntax Error: Element.querySelector no value
 PASS Syntax Error: Element.querySelectorAll: .blox16:not(.blox15[foo="blox14"])
 PASS Syntax Error: Element.querySelector: .blox16:not(.blox15[foo="blox14"])
 PASS Syntax Error: Element.querySelectorAll: div:not(:not(div))
@@ -726,11 +726,11 @@ PASS Disconnected Element supports querySelectorAll
 PASS Disconnected Element.querySelectorAll Empty String
 PASS Disconnected Element.querySelectorAll null
 PASS Disconnected Element.querySelectorAll undefined
-FAIL Disconnected Element.querySelectorAll no value
+PASS Disconnected Element.querySelectorAll no value
 PASS Disconnected Element.querySelector Empty String
 PASS Disconnected Element.querySelector null
 PASS Disconnected Element.querySelector undefined
-FAIL Disconnected Element.querySelector no value
+PASS Disconnected Element.querySelector no value
 PASS Disconnected Element.querySelectorAll: .target :target
 PASS Disconnected Element.querySelectorAll Whitespace Trim: .target :target
 PASS Disconnected Element.querySelector: .target :target
@@ -1148,11 +1148,11 @@ PASS Disconnected Element: StaticNodeList
 PASS Syntax Error: Disconnected Element.querySelectorAll Empty String
 PASS Syntax Error: Disconnected Element.querySelectorAll null
 PASS Syntax Error: Disconnected Element.querySelectorAll undefined
-FAIL Syntax Error: Disconnected Element.querySelectorAll no value
+PASS Syntax Error: Disconnected Element.querySelectorAll no value
 PASS Syntax Error: Disconnected Element.querySelector Empty String
 PASS Syntax Error: Disconnected Element.querySelector null
 PASS Syntax Error: Disconnected Element.querySelector undefined
-FAIL Syntax Error: Disconnected Element.querySelector no value
+PASS Syntax Error: Disconnected Element.querySelector no value
 PASS Syntax Error: Disconnected Element.querySelectorAll: .blox16:not(.blox15[foo="blox14"])
 PASS Syntax Error: Disconnected Element.querySelector: .blox16:not(.blox15[foo="blox14"])
 PASS Syntax Error: Disconnected Element.querySelectorAll: div:not(:not(div))
@@ -1324,11 +1324,11 @@ PASS Fragment supports querySelectorAll
 PASS Fragment.querySelectorAll Empty String
 PASS Fragment.querySelectorAll null
 PASS Fragment.querySelectorAll undefined
-FAIL Fragment.querySelectorAll no value
+PASS Fragment.querySelectorAll no value
 PASS Fragment.querySelector Empty String
 PASS Fragment.querySelector null
 PASS Fragment.querySelector undefined
-FAIL Fragment.querySelector no value
+PASS Fragment.querySelector no value
 PASS Fragment.querySelectorAll: .target :target
 PASS Fragment.querySelectorAll Whitespace Trim: .target :target
 PASS Fragment.querySelector: .target :target
@@ -1629,11 +1629,11 @@ PASS Fragment.querySelector: .plus .t1:hover + .unitTest + .unitTest
 PASS Syntax Error: Fragment.querySelectorAll Empty String
 PASS Syntax Error: Fragment.querySelectorAll null
 PASS Syntax Error: Fragment.querySelectorAll undefined
-FAIL Syntax Error: Fragment.querySelectorAll no value
+PASS Syntax Error: Fragment.querySelectorAll no value
 PASS Syntax Error: Fragment.querySelector Empty String
 PASS Syntax Error: Fragment.querySelector null
 PASS Syntax Error: Fragment.querySelector undefined
-FAIL Syntax Error: Fragment.querySelector no value
+PASS Syntax Error: Fragment.querySelector no value
 PASS Syntax Error: Fragment.querySelectorAll: .blox16:not(.blox15[foo="blox14"])
 PASS Syntax Error: Fragment.querySelector: .blox16:not(.blox15[foo="blox14"])
 PASS Syntax Error: Fragment.querySelectorAll: div:not(:not(div))
@@ -1687,11 +1687,11 @@ PASS Document supports querySelectorAll
 PASS Document.querySelectorAll Empty String
 PASS Document.querySelectorAll null
 PASS Document.querySelectorAll undefined
-FAIL Document.querySelectorAll no value
+PASS Document.querySelectorAll no value
 PASS Document.querySelector Empty String
 PASS Document.querySelector null
 PASS Document.querySelector undefined
-FAIL Document.querySelector no value
+PASS Document.querySelector no value
 PASS Document.querySelectorAll: .target :target
 PASS Document.querySelectorAll Whitespace Trim: .target :target
 PASS Document.querySelector: .target :target
@@ -1992,11 +1992,11 @@ PASS Document.querySelector: .plus .t1:hover + .unitTest + .unitTest
 PASS Syntax Error: Document.querySelectorAll Empty String
 PASS Syntax Error: Document.querySelectorAll null
 PASS Syntax Error: Document.querySelectorAll undefined
-FAIL Syntax Error: Document.querySelectorAll no value
+PASS Syntax Error: Document.querySelectorAll no value
 PASS Syntax Error: Document.querySelector Empty String
 PASS Syntax Error: Document.querySelector null
 PASS Syntax Error: Document.querySelector undefined
-FAIL Syntax Error: Document.querySelector no value
+PASS Syntax Error: Document.querySelector no value
 PASS Syntax Error: Document.querySelectorAll: .blox16:not(.blox15[foo="blox14"])
 PASS Syntax Error: Document.querySelector: .blox16:not(.blox15[foo="blox14"])
 PASS Syntax Error: Document.querySelectorAll: div:not(:not(div))

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index ebf23c5..c04c687 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,21 @@
+2010-12-27  Yael Aharon  <yael.aharon@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        Browser is failing 16 baseline test from Selector API Test Suite
+        https://bugs.webkit.org/show_bug.cgi?id=42968
+
+        Throw an exception if there is no argument to querySelector or 
+        querySelectorAll. This replaces the current behavior of passing the string
+        "undefined" as the argument.
+
+        No new tests, just updating the existing results for 
+        fast/dom/SelectorAPI/resig-SelectorAPI-test.xhtml.
+
+        * dom/Document.idl:
+        * dom/DocumentFragment.idl:
+        * dom/Element.idl:
+
 2010-12-26  MORITA Hajime  <morrita@google.com>
 
         Reviewed by Dan Bernstein.

diff --git a/WebCore/dom/Document.idl b/WebCore/dom/Document.idl
index 138757f..062e42d 100644 (file)
--- a/WebCore/dom/Document.idl
+++ b/WebCore/dom/Document.idl
@@ -231,9 +231,9 @@ module core {
         readonly attribute DOMString compatMode;
 
         // NodeSelector - Selector API
-        Element querySelector(in DOMString selectors)
+        [RequiresAllArguments=Raise] Element querySelector(in DOMString selectors)
             raises(DOMException);
-        NodeList querySelectorAll(in DOMString selectors)
+        [RequiresAllArguments=Raise] NodeList querySelectorAll(in DOMString selectors)
             raises(DOMException);
 
 #if defined(ENABLE_WML) && ENABLE_WML

diff --git a/WebCore/dom/DocumentFragment.idl b/WebCore/dom/DocumentFragment.idl
index 882b62d..ffdcce1 100644 (file)
--- a/WebCore/dom/DocumentFragment.idl
+++ b/WebCore/dom/DocumentFragment.idl
@@ -21,9 +21,9 @@ module core {
 
     interface DocumentFragment : Node {
         // NodeSelector - Selector API
-        Element querySelector(in DOMString selectors)
+        [RequiresAllArguments=Raise] Element querySelector(in DOMString selectors)
             raises(DOMException);
-        NodeList querySelectorAll(in DOMString selectors)
+        [RequiresAllArguments=Raise] NodeList querySelectorAll(in DOMString selectors)
             raises(DOMException);
     };
 

diff --git a/WebCore/dom/Element.idl b/WebCore/dom/Element.idl
index 2b62a1a..7cb63c2 100644 (file)
--- a/WebCore/dom/Element.idl
+++ b/WebCore/dom/Element.idl
@@ -104,9 +104,9 @@ module core {
 #endif
 
         // NodeSelector - Selector API
-        Element querySelector(in DOMString selectors)
+        [RequiresAllArguments=Raise] Element querySelector(in DOMString selectors)
             raises(DOMException);
-        NodeList querySelectorAll(in DOMString selectors)
+        [RequiresAllArguments=Raise] NodeList querySelectorAll(in DOMString selectors)
             raises(DOMException);
 
         // WebKit extension, pending specification.