drm/amdgpu: remove deprecated MES version vars
authorGraham Sider <Graham.Sider@amd.com>
Tue, 25 Oct 2022 18:47:05 +0000 (14:47 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 27 Oct 2022 19:12:08 +0000 (15:12 -0400)
MES scheduler and kiq versions are stored in mes.sched_version and
mes.kiq_version, respectively, which are read from a register after
their queues are initialized. Remove mes.ucode_fw_version and
mes.data_fw_version which tried to read this versioning info from the
firmware headers (which don't contain this information).

Signed-off-by: Graham Sider <Graham.Sider@amd.com>
Reviewed-by: Jack Xiao <Jack.Xiao@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.h
drivers/gpu/drm/amd/amdgpu/mes_v10_1.c
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c

index ad980f4..97c05d0 100644 (file)
@@ -91,14 +91,12 @@ struct amdgpu_mes {
        struct amdgpu_bo                *ucode_fw_obj[AMDGPU_MAX_MES_PIPES];
        uint64_t                        ucode_fw_gpu_addr[AMDGPU_MAX_MES_PIPES];
        uint32_t                        *ucode_fw_ptr[AMDGPU_MAX_MES_PIPES];
-       uint32_t                        ucode_fw_version[AMDGPU_MAX_MES_PIPES];
        uint64_t                        uc_start_addr[AMDGPU_MAX_MES_PIPES];
 
        /* mes ucode data */
        struct amdgpu_bo                *data_fw_obj[AMDGPU_MAX_MES_PIPES];
        uint64_t                        data_fw_gpu_addr[AMDGPU_MAX_MES_PIPES];
        uint32_t                        *data_fw_ptr[AMDGPU_MAX_MES_PIPES];
-       uint32_t                        data_fw_version[AMDGPU_MAX_MES_PIPES];
        uint64_t                        data_start_addr[AMDGPU_MAX_MES_PIPES];
 
        /* eop gpu obj */
index 067d100..1abdf8b 100644 (file)
@@ -415,10 +415,6 @@ static int mes_v10_1_init_microcode(struct amdgpu_device *adev,
 
        mes_hdr = (const struct mes_firmware_header_v1_0 *)
                adev->mes.fw[pipe]->data;
-       adev->mes.ucode_fw_version[pipe] =
-               le32_to_cpu(mes_hdr->mes_ucode_version);
-       adev->mes.ucode_fw_version[pipe] =
-               le32_to_cpu(mes_hdr->mes_ucode_data_version);
        adev->mes.uc_start_addr[pipe] =
                le32_to_cpu(mes_hdr->mes_uc_start_addr_lo) |
                ((uint64_t)(le32_to_cpu(mes_hdr->mes_uc_start_addr_hi)) << 32);
index f141fad..8ca3417 100644 (file)
@@ -485,10 +485,6 @@ static int mes_v11_0_init_microcode(struct amdgpu_device *adev,
 
        mes_hdr = (const struct mes_firmware_header_v1_0 *)
                adev->mes.fw[pipe]->data;
-       adev->mes.ucode_fw_version[pipe] =
-               le32_to_cpu(mes_hdr->mes_ucode_version);
-       adev->mes.ucode_fw_version[pipe] =
-               le32_to_cpu(mes_hdr->mes_ucode_data_version);
        adev->mes.uc_start_addr[pipe] =
                le32_to_cpu(mes_hdr->mes_uc_start_addr_lo) |
                ((uint64_t)(le32_to_cpu(mes_hdr->mes_uc_start_addr_hi)) << 32);