media: cx23885: make const array buf static, reduces object code size
authorColin Ian King <colin.king@canonical.com>
Thu, 7 Sep 2017 09:50:23 +0000 (05:50 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sat, 23 Sep 2017 12:30:25 +0000 (08:30 -0400)
Don't populate the array buf on the stack, instead make it static.
Makes the object code smaller by over 240 bytes:

Before:
   text    data     bss     dec     hex filename
  21689   22992     416   45097    b029 cx23885-cards.o

After:
   text    data     bss     dec     hex filename
  21348   23088     416   44852    af34 cx23885-cards.o

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/pci/cx23885/cx23885-cards.c

index 78a8836..28eab9c 100644 (file)
@@ -1323,7 +1323,7 @@ static void hauppauge_eeprom(struct cx23885_dev *dev, u8 *eeprom_data)
 static void tbs_card_init(struct cx23885_dev *dev)
 {
        int i;
-       const u8 buf[] = {
+       static const u8 buf[] = {
                0xe0, 0x06, 0x66, 0x33, 0x65,
                0x01, 0x17, 0x06, 0xde};