fix svace issue

- WID 3137790, 313819, 314741, 315855

Change-Id: I93e058c6beaf5479edf3f33dfa86e38f042d480d
Signed-off-by: saerome.kim <saerome.kim@samsung.com>

diff --git a/src/wmesh-interface.c b/src/wmesh-interface.c
index b4a2e3d..81a8fc2 100644 (file)
--- a/src/wmesh-interface.c
+++ b/src/wmesh-interface.c
@@ -235,12 +235,14 @@ char* wmesh_interface_get_address(const char* if_name)
        snprintf(buf, sizeof(buf), "/sys/class/net/%s/address", if_name);
        pf = fopen(buf, "r");
        if (NULL != pf) {
-               fgets(buf, 31, pf);
-               WMESH_LOGD("Interface[%s] address[%s]", if_name, buf);
-
-               if (strlen(buf) > 0)
-                       result = g_strdup(buf);
+               if (!fgets(buf, 31, pf) || ferror(pf) || feof(pf)) {
+                       WMESH_LOGE("Error open Inerface[%s]", if_name);
+               } else {
+                       WMESH_LOGD("Interface[%s] address[%s]", if_name, buf);
 
+                       if (strlen(buf) > 0)
+                               result = g_strdup(buf);
+               }
                fclose(pf);
        }
 

diff --git a/src/wmesh-peer-monitor.c b/src/wmesh-peer-monitor.c
index 431ae16..87205c9 100644 (file)
--- a/src/wmesh-peer-monitor.c
+++ b/src/wmesh-peer-monitor.c
@@ -226,7 +226,10 @@ static gboolean _on_mesh_monitor_cb(gpointer pdata)
 #if 0
                        _get_mpath_info(service);
 #endif
-                       _get_station_info(service);
+                       ret = _get_station_info(service);
+                       if (WMESHD_ERROR_NONE != ret) {
+                               WMESH_LOGW("Erro in get station info (%d)", ret);
+                       }
                }
        }
 

diff --git a/src/wmesh-softap.c b/src/wmesh-softap.c
index bd96348..a65600a 100644 (file)
--- a/src/wmesh-softap.c
+++ b/src/wmesh-softap.c
@@ -216,7 +216,10 @@ static int __read_hostapd_config(char **softap_interface, char **ssid,
 
        *security = 0;
 
-       while (NULL != fgets(buf, sizeof(buf), fp)) {
+       while (1) {
+               if (!fgets(buf, sizeof(buf), fp) || ferror(fp) || feof(fp))
+                       break;
+
                if (strncmp(buf, "interface", strlen("interface")) == 0) {
                        *softap_interface = g_strdup(strrchr(buf, '=') + 1);
                        WMESH_LOGD("Interface: %s", *softap_interface);
@@ -438,7 +441,12 @@ static int __execute_hostapd()
                /* LCOV_EXCL_STOP */
        } else {
                /* Reap child */
-               waitpid(pid, &status, 0);
+               if (-1 == waitpid(pid, &status, 0)) {
+                       if (errno != EINTR) {
+                               WMESH_LOGE("   Faild to reap child [%d] errono(%d)", pid, errno);
+                               return WMESHD_ERROR_OPERATION_FAILED;
+                       }
+               }
                WMESH_LOGD("  child [%d] reaped with status(%d)", pid, status);
        }