gallium/util: make sure cache line size is not zero
authorLeonid Shatz <leonid.shatz@ravellosystems.com>
Wed, 31 Dec 2014 18:07:44 +0000 (19:07 +0100)
committerRoland Scheidegger <sroland@vmware.com>
Mon, 5 Jan 2015 16:58:39 +0000 (17:58 +0100)
The "normal" detection (querying clflush size) already made sure it is
non-zero, however another method did not. This lead to crashes if this
value happened to be zero (apparently can happen in virtualized environments
at least).
This fixes https://bugs.freedesktop.org/show_bug.cgi?id=87913

Cc: "10.4" <mesa-stable@lists.freedesktop.org>
src/gallium/auxiliary/util/u_cpu_detect.c

index 28197f4..23ab46c 100644 (file)
@@ -409,8 +409,12 @@ util_cpu_detect(void)
       }
 
       if (regs[0] >= 0x80000006) {
+         /* should we really do this if the clflush size above worked? */
+         unsigned int cacheline;
          cpuid(0x80000006, regs2);
-         util_cpu_caps.cacheline = regs2[2] & 0xFF;
+         cacheline = regs2[2] & 0xFF;
+         if (cacheline > 0)
+            util_cpu_caps.cacheline = cacheline;
       }
 
       if (!util_cpu_caps.has_sse) {