HID: playstation: fix unused variable in ps_battery_get_property.
authorRoderick Colenbrander <roderick.colenbrander@sony.com>
Fri, 12 Feb 2021 06:41:00 +0000 (22:41 -0800)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Wed, 17 Feb 2021 17:34:55 +0000 (18:34 +0100)
The ret variable in ps_battery_get_property is set in an error path,
but never actually returned. Change the function to return ret.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
drivers/hid/hid-playstation.c

index 84f484f..f279064 100644 (file)
@@ -333,7 +333,7 @@ static int ps_battery_get_property(struct power_supply *psy,
        uint8_t battery_capacity;
        int battery_status;
        unsigned long flags;
-       int ret;
+       int ret = 0;
 
        spin_lock_irqsave(&dev->lock, flags);
        battery_capacity = dev->battery_capacity;
@@ -358,7 +358,7 @@ static int ps_battery_get_property(struct power_supply *psy,
                break;
        }
 
-       return 0;
+       return ret;
 }
 
 static int ps_device_register_battery(struct ps_device *dev)