mips: ralink: fix a refcount leak in ill_acc_of_setup()
authorHangyu Hua <hbh25y@gmail.com>
Mon, 28 Feb 2022 07:35:37 +0000 (15:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Apr 2022 18:59:07 +0000 (20:59 +0200)
[ Upstream commit 4a0a1436053b17e50b7c88858fb0824326641793 ]

of_node_put(np) needs to be called when pdev == NULL.

Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/mips/ralink/ill_acc.c

index bdf5380..bea857c 100644 (file)
@@ -61,6 +61,7 @@ static int __init ill_acc_of_setup(void)
        pdev = of_find_device_by_node(np);
        if (!pdev) {
                pr_err("%pOFn: failed to lookup pdev\n", np);
+               of_node_put(np);
                return -EINVAL;
        }