projects
/
kernel
/
kernel-generic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d6d79a7
)
Input: psmouse - fix incorrect validate_byte check in OLPC protocol
author
Andres Salomon
<dilinger@queued.net>
Tue, 11 Nov 2008 14:52:21 +0000
(09:52 -0500)
committer
Dmitry Torokhov
<dmitry.torokhov@gmail.com>
Tue, 11 Nov 2008 16:32:07 +0000
(11:32 -0500)
The validate_byte check logic was backwards; it should return true for
an *invalid* packet. Thanks to Jeremy Katz for spotting this one.
Signed-off-by: Andres Salomon <dilinger@debian.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
drivers/input/mouse/hgpk.c
patch
|
blob
|
history
diff --git
a/drivers/input/mouse/hgpk.c
b/drivers/input/mouse/hgpk.c
index
e82d342
..
88f04bf
100644
(file)
--- a/
drivers/input/mouse/hgpk.c
+++ b/
drivers/input/mouse/hgpk.c
@@
-125,7
+125,7
@@
static void hgpk_spewing_hack(struct psmouse *psmouse,
*/
static int hgpk_validate_byte(unsigned char *packet)
{
- return (packet[0] & 0x0C)
=
= 0x08;
+ return (packet[0] & 0x0C)
!
= 0x08;
}
static void hgpk_process_packet(struct psmouse *psmouse)