pwm: lpc32xx: Implement .apply() callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sat, 7 May 2022 08:29:01 +0000 (10:29 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Fri, 20 May 2022 14:29:01 +0000 (16:29 +0200)
To eventually get rid of all legacy drivers convert this driver to the
modern world implementing .apply().
This just pushed a variant of pwm_apply_legacy() into the driver that was
slightly simplified because the driver doesn't provide a .set_polarity()
callback.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-lpc32xx.c

index ddeab56..86a0ea0 100644 (file)
@@ -88,10 +88,33 @@ static void lpc32xx_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
        clk_disable_unprepare(lpc32xx->clk);
 }
 
+static int lpc32xx_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
+                            const struct pwm_state *state)
+{
+       int err;
+
+       if (state->polarity != PWM_POLARITY_NORMAL)
+               return -EINVAL;
+
+       if (!state->enabled) {
+               if (pwm->state.enabled)
+                       lpc32xx_pwm_disable(chip, pwm);
+
+               return 0;
+       }
+
+       err = lpc32xx_pwm_config(pwm->chip, pwm, state->duty_cycle, state->period);
+       if (err)
+               return err;
+
+       if (!pwm->state.enabled)
+               err = lpc32xx_pwm_enable(chip, pwm);
+
+       return err;
+}
+
 static const struct pwm_ops lpc32xx_pwm_ops = {
-       .config = lpc32xx_pwm_config,
-       .enable = lpc32xx_pwm_enable,
-       .disable = lpc32xx_pwm_disable,
+       .apply = lpc32xx_pwm_apply,
        .owner = THIS_MODULE,
 };