um: net: Eliminate NULL test after alloc_bootmem
authorHimangi Saraogi <himangi774@gmail.com>
Sat, 19 Jul 2014 11:34:05 +0000 (17:04 +0530)
committerRichard Weinberger <richard@nod.at>
Mon, 13 Oct 2014 19:46:26 +0000 (21:46 +0200)
alloc_bootmem and related functions never return NULL. Thus a NULL
test or memset after calls to these functions is unnecessary.

The following Coccinelle semantic patch was used for making the change:

@@
expression E;
statement S;
@@

E = \(alloc_bootmem\|alloc_bootmem_low\|alloc_bootmem_pages\|alloc_bootmem_low_pages\)(...)
... when != E
- if (E == NULL) S

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Richard Weinberger <richard@nod.at>
arch/um/drivers/net_kern.c

index 7d26d9c..f70dd54 100644 (file)
@@ -659,10 +659,6 @@ static int __init eth_setup(char *str)
        }
 
        new = alloc_bootmem(sizeof(*new));
-       if (new == NULL) {
-               printk(KERN_ERR "eth_init : alloc_bootmem failed\n");
-               return 1;
-       }
 
        INIT_LIST_HEAD(&new->list);
        new->index = n;