e_comp_wl: Remove unnecessary subsurface check 13/321213/1
authorSeunghun Lee <shiin.lee@samsung.com>
Fri, 14 Mar 2025 08:52:16 +0000 (17:52 +0900)
committerTizen Window System <tizen.windowsystem@gmail.com>
Mon, 17 Mar 2025 09:28:07 +0000 (18:28 +0900)
The current code includes a check if the ec is for a subsurface to
prevent compositor from considering wayland_tbm buffer transform,
assuming that clients should not set the wayland_tbm buffer transform
for subsurfaces.

However, this assumption is implicit and makes the code harder to
maintain. To maintain consistency with other surfaces, it is better to
remove the subsurface check.

If a client attempts to set the wayland_tbm buffer transform for a
subsurface, it should be handled in different way - It's undefined
behavior for now. For example, we can raise a protocol error to be
explicit.

This change removes the unnecessary subsurface check, making the code
more maintainable and consistent with other surfaces.

Change-Id: I036ee6cf162edc65f953b64ffce5c8268871dfa2

src/bin/server/e_comp_wl.c

index 79c03110fdf778159f6ac3b9e92d1f1ad774e7eb..6d9aa48e0562a18a50abdc8ec32f24ceec747a12 100644 (file)
@@ -412,9 +412,6 @@ e_comp_wl_output_buffer_transform_get(E_Client *ec)
 
    buffer_transform = e_surface_buffer_transform_get(surface);
 
-   if (e_comp_wl_subsurface_check(ec))
-     return buffer_transform;
-
    buffer = e_surface_buffer_try_get(surface);
 
    if (!buffer ||