s390/qeth: remove fake_broadcast attribute
authorJulian Wiedmann <jwi@linux.ibm.com>
Fri, 27 Mar 2020 10:19:32 +0000 (11:19 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Mar 2020 22:36:56 +0000 (15:36 -0700)
Ever since commit 4a71df50047f ("qeth: new qeth device driver") introduced
this attribute, it can be read & written but has no actual effect.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core.h
drivers/s390/net/qeth_l3_sys.c

index 5f85617..acda230 100644 (file)
@@ -710,7 +710,6 @@ struct qeth_card_options {
        struct qeth_ipa_caps adp; /* Adapter parameters */
        struct qeth_sbp_info sbp; /* SETBRIDGEPORT options */
        struct qeth_vnicc_info vnicc; /* VNICC options */
-       int fake_broadcast;
        enum qeth_discipline_id layer;
        enum qeth_ipa_isolation_modes isolation;
        enum qeth_ipa_isolation_modes prev_isolation;
index a3d1c3b..dd0b390 100644 (file)
@@ -133,40 +133,6 @@ static ssize_t qeth_l3_dev_route6_store(struct device *dev,
 static DEVICE_ATTR(route6, 0644, qeth_l3_dev_route6_show,
                        qeth_l3_dev_route6_store);
 
-static ssize_t qeth_l3_dev_fake_broadcast_show(struct device *dev,
-                       struct device_attribute *attr, char *buf)
-{
-       struct qeth_card *card = dev_get_drvdata(dev);
-
-       return sprintf(buf, "%i\n", card->options.fake_broadcast? 1:0);
-}
-
-static ssize_t qeth_l3_dev_fake_broadcast_store(struct device *dev,
-               struct device_attribute *attr, const char *buf, size_t count)
-{
-       struct qeth_card *card = dev_get_drvdata(dev);
-       char *tmp;
-       int i, rc = 0;
-
-       mutex_lock(&card->conf_mutex);
-       if (card->state != CARD_STATE_DOWN) {
-               rc = -EPERM;
-               goto out;
-       }
-
-       i = simple_strtoul(buf, &tmp, 16);
-       if ((i == 0) || (i == 1))
-               card->options.fake_broadcast = i;
-       else
-               rc = -EINVAL;
-out:
-       mutex_unlock(&card->conf_mutex);
-       return rc ? rc : count;
-}
-
-static DEVICE_ATTR(fake_broadcast, 0644, qeth_l3_dev_fake_broadcast_show,
-                  qeth_l3_dev_fake_broadcast_store);
-
 static ssize_t qeth_l3_dev_sniffer_show(struct device *dev,
                struct device_attribute *attr, char *buf)
 {
@@ -305,7 +271,6 @@ static DEVICE_ATTR(hsuid, 0644, qeth_l3_dev_hsuid_show,
 static struct attribute *qeth_l3_device_attrs[] = {
        &dev_attr_route4.attr,
        &dev_attr_route6.attr,
-       &dev_attr_fake_broadcast.attr,
        &dev_attr_sniffer.attr,
        &dev_attr_hsuid.attr,
        NULL,