mtd: nand: denali: use upper/lower_32_bits() macro for clean-up
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Fri, 22 Sep 2017 03:46:46 +0000 (12:46 +0900)
committerBoris Brezillon <boris.brezillon@free-electrons.com>
Fri, 22 Sep 2017 07:04:34 +0000 (09:04 +0200)
I used (uint64_t) cast to avoid "right shift count >= width of type"
warning.  <linux/kernel.h> provides nice helpers to cater to it.
The code will be cleaner, and easier to understand.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
drivers/mtd/nand/denali.c

index 02ce310..e567ad9 100644 (file)
@@ -469,10 +469,10 @@ static void denali_setup_dma64(struct denali_nand_info *denali,
                          0x01002000 | (64 << 16) | (write << 8) | page_count);
 
        /* 2. set memory low address */
-       denali_host_write(denali, mode, dma_addr);
+       denali_host_write(denali, mode, lower_32_bits(dma_addr));
 
        /* 3. set memory high address */
-       denali_host_write(denali, mode, (uint64_t)dma_addr >> 32);
+       denali_host_write(denali, mode, upper_32_bits(dma_addr));
 }
 
 static void denali_setup_dma32(struct denali_nand_info *denali,