Automatically CC someone from Apple on any changes to Obj-C public API

https://bugs.webkit.org/show_bug.cgi?id=77053

Reviewed by Timothy Hatcher.

This has long been de-facto practice, seems now that we have
fancy watchlist support, we should just make the tools
do this automatically.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Tools/ChangeLog b/Tools/ChangeLog
index 0d0b726..cc8ef09 100644 (file)
--- a/Tools/ChangeLog
+++ b/Tools/ChangeLog
@@ -1,3 +1,16 @@
+2012-01-25  Eric Seidel  <eric@webkit.org>
+
+        Automatically CC someone from Apple on any changes to Obj-C public API
+        https://bugs.webkit.org/show_bug.cgi?id=77053
+
+        Reviewed by Timothy Hatcher.
+
+        This has long been de-facto practice, seems now that we have
+        fancy watchlist support, we should just make the tools
+        do this automatically.
+
+        * Scripts/webkitpy/common/config/watchlist:
+
 2012-01-25  Antoine Labour  <piman@chromium.org>
 
         Updating status in committers.py.

diff --git a/Tools/Scripts/webkitpy/common/config/watchlist b/Tools/Scripts/webkitpy/common/config/watchlist
index fce7450..54e732f 100755 (executable)
--- a/Tools/Scripts/webkitpy/common/config/watchlist
+++ b/Tools/Scripts/webkitpy/common/config/watchlist
@@ -21,6 +21,9 @@
         "ChromiumPublicApi": {
             "filename": r"Source/WebKit/chromium/public/"
         },
+        "AppleMacPublicApi": {
+            "filename": r"Source/WebCore/bindings/objc/PublicDOMInterfaces.h"
+        },
         "Forms": {
             "filename": r"Source/WebCore/html/HTML(FieldSet|Form|FormControl|Input|Label"
                         r"|OptGroup|Option|Select|TextArea|TextFormControl)Element\."
@@ -138,6 +141,7 @@
         "ChromiumDumpRenderTree": [ "tkent@chromium.org", ],
         "ChromiumGraphics": [ "jamesr@chromium.org", "cc-bugs@google.com" ],
         "ChromiumPublicApi": [ "fishd@chromium.org", ],
+        "AppleMacPublicApi": [ "timothy@apple.com" ],
         "Forms": [ "tkent@chromium.org", ],
         "GStreamerGraphics": [ "pnormand@igalia.com", "gns@gnome.org" ],
         "WebIDL": [ "abarth@webkit.org", "ojan@chromium.org" ],
@@ -162,6 +166,10 @@
     "MESSAGE_RULES": {
         "ChromiumPublicApi": [ "Please wait for approval from fishd@chromium.org before submitting "
                                "because this patch contains changes to the Chromium public API.", ],
+        "AppleMacPublicApi": [ "Please wait for approval from timothy@apple.com (or another member "
+                               "of the Apple Safari Team) before submitting "
+                               "because this patch contains changes to the Apple Mac "
+                               "WebKit.framework public API.", ],
         "GtkWebKit2PublicAPI": [ "Thanks for the patch. If this patch contains new public API "
                                  "please make sure it follows the guidelines for new WebKit2 GTK+ API. "
                                  "See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API", ],