ipv6: exthdrs: use swap() instead of open coding it
authorGuo Zhengkui <guozhengkui@vivo.com>
Tue, 12 Apr 2022 03:20:58 +0000 (11:20 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Apr 2022 11:20:58 +0000 (12:20 +0100)
Address the following coccicheck warning:
net/ipv6/exthdrs.c:620:44-45: WARNING opportunity for swap()

by using swap() for the swapping of variable values and drop
the tmp (`addr`) variable that is not needed any more.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/exthdrs.c

index 658d5ea..a2094aa 100644 (file)
@@ -487,7 +487,6 @@ static int ipv6_rpl_srh_rcv(struct sk_buff *skb)
        struct net *net = dev_net(skb->dev);
        struct inet6_dev *idev;
        struct ipv6hdr *oldhdr;
-       struct in6_addr addr;
        unsigned char *buf;
        int accept_rpl_seg;
        int i, err;
@@ -616,9 +615,7 @@ looped_back:
                return -1;
        }
 
-       addr = ipv6_hdr(skb)->daddr;
-       ipv6_hdr(skb)->daddr = ohdr->rpl_segaddr[i];
-       ohdr->rpl_segaddr[i] = addr;
+       swap(ipv6_hdr(skb)->daddr, ohdr->rpl_segaddr[i]);
 
        ipv6_rpl_srh_compress(chdr, ohdr, &ipv6_hdr(skb)->daddr, n);