scsi: ips: make array 'options' static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Fri, 6 Sep 2019 16:45:22 +0000 (17:45 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 1 Oct 2019 02:46:40 +0000 (22:46 -0400)
Don't populate the array 'options' on the stack but instead make it static
const. Makes the object code smaller by 143 bytes.

Before:
   text    data     bss     dec     hex filename
  94483   11272    1184  106939   1a1bb drivers/scsi/ips.o

After:
   text    data     bss     dec     hex filename
  94244   11368    1184  106796   1a12c drivers/scsi/ips.o

(gcc version 9.2.1, amd64)

Link: https://lore.kernel.org/r/20190906164522.5644-1-colin.king@canonical.com
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ips.c

index e8bc8d3..f256729 100644 (file)
@@ -498,7 +498,7 @@ ips_setup(char *ips_str)
        int i;
        char *key;
        char *value;
-       IPS_OPTION options[] = {
+       static const IPS_OPTION options[] = {
                {"noi2o", &ips_force_i2o, 0},
                {"nommap", &ips_force_memio, 0},
                {"ioctlsize", &ips_ioctlsize, IPS_IOCTL_SIZE},