soundwire: stream: simplify check on port range
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Wed, 26 Jan 2022 01:16:59 +0000 (09:16 +0800)
committerVinod Koul <vkoul@kernel.org>
Fri, 11 Feb 2022 06:45:36 +0000 (12:15 +0530)
Pass the index directly to sdw_is_valid_port_range(), this will be
useful for further simplifications.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20220126011715.28204-4-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/stream.c

index a75d357..3ac2e5a 100644 (file)
@@ -1177,12 +1177,10 @@ static int sdw_config_stream(struct device *dev,
        return 0;
 }
 
-static int sdw_is_valid_port_range(struct device *dev,
-                                  struct sdw_port_runtime *p_rt)
+static int sdw_is_valid_port_range(struct device *dev, int num)
 {
-       if (!SDW_VALID_PORT_RANGE(p_rt->num)) {
-               dev_err(dev,
-                       "SoundWire: Invalid port number :%d\n", p_rt->num);
+       if (!SDW_VALID_PORT_RANGE(num)) {
+               dev_err(dev, "SoundWire: Invalid port number :%d\n", num);
                return -EINVAL;
        }
 
@@ -1249,7 +1247,7 @@ static int sdw_slave_port_config(struct sdw_slave *slave,
                 * TODO: Check valid port range as defined by DisCo/
                 * slave
                 */
-               ret = sdw_is_valid_port_range(&slave->dev, p_rt);
+               ret = sdw_is_valid_port_range(&slave->dev, port_config[i].num);
                if (ret < 0) {
                        kfree(p_rt);
                        return ret;