rtmp2: Fix allocation of GstRtmpMeta
authorJan Alexander Steffens (heftig) <jan.steffens@ltnglobal.com>
Sat, 4 Jun 2022 15:23:00 +0000 (17:23 +0200)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Mon, 6 Jun 2022 15:51:07 +0000 (15:51 +0000)
Use the right size.

On 64-bit platforms, `GstMetaInfo` is larger than `GstRtmpMeta`, which
masked this bug. On 32-bit platforms, it causes crashes. Thanks to
@maxatka for discovering this.

Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1721
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2553>

subprojects/gst-plugins-bad/gst/rtmp2/rtmp/rtmpmessage.c

index f59c09a..d284cb3 100644 (file)
@@ -207,7 +207,7 @@ gst_rtmp_meta_get_info (void)
 
   if (g_once_init_enter (&rtmp_meta_info)) {
     const GstMetaInfo *meta = gst_meta_register (GST_RTMP_META_API_TYPE,
-        "GstRtmpMeta", sizeof *meta, gst_rtmp_meta_init, NULL,
+        "GstRtmpMeta", sizeof (GstRtmpMeta), gst_rtmp_meta_init, NULL,
         gst_rtmp_meta_transform);
     g_once_init_leave (&rtmp_meta_info, meta);
   }