- fixed func call syntax on lower to lower()

- added test cases for trying to test GETS on mixed-case schemas

diff --git a/requests/adapters.py b/requests/adapters.py
index b45027965c46f8121782bda6cc625b0f496f4053..b4f5bf6c1d7e1d1487f74f98b3fb5a809c128fa6 100644 (file)
--- a/requests/adapters.py
+++ b/requests/adapters.py
@@ -118,7 +118,7 @@ class HTTPAdapter(BaseAdapter):
         :param verify: Whether we should actually verify the certificate.
         :param cert: The SSL certificate to verify.
         """
-        if url.lower.startswith('https') and verify:
+        if url.lower().startswith('https') and verify:
 
             cert_loc = None
 

diff --git a/requests/sessions.py b/requests/sessions.py
index ccd76340d5a99c09ef39413712ebc53b6931fd9e..a55f84da88a13a6ee9ab9ec184b7b749e71359b8 100644 (file)
--- a/requests/sessions.py
+++ b/requests/sessions.py
@@ -467,7 +467,7 @@ class Session(SessionRedirectMixin):
         """Returns the appropriate connnection adapter for the given URL."""
         for (prefix, adapter) in self.adapters.items():
 
-            if url.lower.startswith(prefix):
+            if url.lower().startswith(prefix):
                 return adapter
 
         # Nothing matches :-/

diff --git a/test_requests.py b/test_requests.py
index 4a4831e5b2633f107dbea016595a72cbc4945257..36006008303d6a6dc1c60d3b87a691782ffe51f4 100755 (executable)
--- a/test_requests.py
+++ b/test_requests.py
@@ -87,6 +87,27 @@ class RequestsTestCase(unittest.TestCase):
         self.assertEqual(request.url,
             "http://example.com/path?key=value&a=b#fragment")
 
+    def test_mixed_case_scheme_acceptable(self):
+        s = requests.Session()
+        r = requests.Request('GET', 'HTTP://httbin.org/get')
+        r = s.send(r.prepare())
+        self.assertEqual(r.status_code,200)
+        r = requests.Request('GET', 'hTTp://httbin.org/get')
+        r = s.send(r.prepare())
+        self.assertEqual(r.status_code,200)
+        r = requests.Request('GET', 'HttP://httbin.org/get')
+        r = s.send(r.prepare())
+        self.assertEqual(r.status_code,200)
+        r = requests.Request('GET', 'HTTPS://httbin.org/get')
+        r = s.send(r.prepare())
+        self.assertEqual(r.status_code,200)
+        r = requests.Request('GET', 'hTTps://httbin.org/get')
+        r = s.send(r.prepare())
+        self.assertEqual(r.status_code,200)
+        r = requests.Request('GET', 'HttPs://httbin.org/get')
+        r = s.send(r.prepare())
+        self.assertEqual(r.status_code,200)
+
     def test_HTTP_200_OK_GET_ALTERNATIVE(self):
         r = requests.Request('GET', httpbin('get'))
         s = requests.Session()